Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220511065548.3402408-1-yangyingliang@huawei.com>
In-Reply-To: <20220511065548.3402408-1-yangyingliang@huawei.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Wed, 18 May 2022 20:39:47 +0100
Message-ID: <CA+V-a8vE5UHnEQRKNEnfbnFtZ=Zj1BWdh9YxpL60nsjSnJJ89Q@mail.gmail.com>
Subject: Re: [PATCH] media: davinci: vpif: add missing of_node_put() in vpif_probe()
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 11, 2022 at 7:44 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> of_graph_get_next_endpoint() returns an 'endpoint' node pointer
> with refcount incremented. The refcount should be decremented
> before returning from vpif_probe().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/media/platform/ti/davinci/vpif.c | 1 +
>  1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/ti/davinci/vpif.c b/drivers/media/platform/ti/davinci/vpif.c
> index 97ef770266af..da27da4c165a 100644
> --- a/drivers/media/platform/ti/davinci/vpif.c
> +++ b/drivers/media/platform/ti/davinci/vpif.c
> @@ -469,6 +469,7 @@ static int vpif_probe(struct platform_device *pdev)
>                                               endpoint);
>         if (!endpoint)
>                 return 0;
> +       of_node_put(endpoint);
>
>         /*
>          * For DT platforms, manually create platform_devices for
> --
> 2.25.1
>