Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 22:00:10 +0200
From:   Eugene Syromiatnikov <esyr@redhat.com>
To:     Yonghong Song <yhs@fb.com>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf v3 1/2] bpf_trace: check size for overflow in
 bpf_kprobe_multi_link_attach
Message-ID: <20220518200010.GA29226@asgard.redhat.com>
References: <cover.1652876187.git.esyr@redhat.com>
 <39c4a91f2867684dc51c5395d26cb56ffe9d995d.1652876188.git.esyr@redhat.com>
 <412bf136-6a5b-f442-1e84-778697e2b694@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <412bf136-6a5b-f442-1e84-778697e2b694@fb.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Wed, May 18, 2022 at 09:34:22AM -0700, Yonghong Song wrote:
> On 5/18/22 5:22 AM, Eugene Syromiatnikov wrote:
> >-	size = cnt * sizeof(*syms);
> >+	if (check_mul_overflow(cnt, (u32)sizeof(*syms), &size))
> >+		return -EOVERFLOW;
> 
> In mm/util.c kvmalloc_node(), we have
> 
>         /* Don't even allow crazy sizes */
>         if (unlikely(size > INT_MAX)) {
>                 WARN_ON_ONCE(!(flags & __GFP_NOWARN));
>                 return NULL;
>         }
> 
> Basically the maximum size to be allocated in INT_MAX.
> 
> Here, we have 'size' as u32, which means if the size is 0xffff0000,
> the check_mul_overflow will return false (no overflow) but
> kvzalloc will still have a warning.
> 
> I think we should change the type of 'size' to be 'int' which
> should catch the above case and be consistent with
> what kvmalloc_node() intends to warn.

Huh, it's a bitmore complicated as check_mul_overflow requires types to
match; what do you think about

+	if (check_mul_overflow(cnt, (u32)sizeof(*syms), &size) || size > INT_MAX)

?