Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Besar Wicaksono <bwicaksono@nvidia.com>
To:     "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "thanu.rangarajan@arm.com" <thanu.rangarajan@arm.com>,
        "Michael.Williams@arm.com" <Michael.Williams@arm.com>,
        "suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
        Thierry Reding <treding@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Vikram Sethi <vsethi@nvidia.com>
Subject: RE: [PATCH v2 1/2] perf: coresight_pmu: Add support for ARM CoreSight
 PMU driver
Thread-Topic: [PATCH v2 1/2] perf: coresight_pmu: Add support for ARM
 CoreSight PMU driver
Thread-Index: AQHYaHlD4fvleNsNzkCmVlWU5lNRqq0kPV+AgADP/wA=
Date:   Wed, 18 May 2022 20:10:41 +0000
Message-ID: <SJ0PR12MB567669E26BF743C951AADD28A0D19@SJ0PR12MB5676.namprd12.prod.outlook.com>
References: <20220515163044.50055-2-bwicaksono@nvidia.com>
 <202205181534.wuyBFt9d-lkp@intel.com>
In-Reply-To: <202205181534.wuyBFt9d-lkp@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xgNIn0+td7qAI7eT8/CKzaNB6Cv4dKyQfiqXTzSebMnUX7AfF6h/+QI2vKWm?=
 =?us-ascii?Q?30GTpPmla76+6/fDOfuTYU/9iHbi4yJ6lSHNbrBRuHVQagjufkG/lyHK/XkR?=
 =?us-ascii?Q?fDdnydeaLGEnVp6CiMOnSA1AnmaQ9NcQwoqtYZ+r/5QfkKAjQWIElpE/cYTe?=
 =?us-ascii?Q?CuF4fJbaC5oC/LofcQyD9NWxZzfVMmv/jM1GQdzsd+jiA6858Aw/O3iYkZNq?=
 =?us-ascii?Q?ZYXe7BefqYglcdXbG9fl395Ed2bUNPSvdTraESdhKeqFO/pq/OBt5Y/w110l?=
 =?us-ascii?Q?e6+DYpbNQXe2lP5bgTJJbb8RakkM0VM3LG5zQOhW95O3kUSNy7n8f1Lw+Raz?=
 =?us-ascii?Q?tEVg+s0p9My3jY2ZpSt6k6MYvq1BWJm8Uhs8yq5BI+hZhLxlgA9IxONac2ag?=
 =?us-ascii?Q?zywX+9GFsEEXuP855slISv66DWzQdCcs8NZq3wAmjf1meCp2I5U5LMkJHPNg?=
 =?us-ascii?Q?RJ29ZzE2zxTI4EeZMgxFYSCIdY7/2L2/2KDcereg6QoBEe6ccp0dJM24YdFt?=
 =?us-ascii?Q?RClovwzFWybZExeMvQIcwEU0JrE2Uq5K2meOZhXNpv7k2oM0mvqDD5piiOX0?=
 =?us-ascii?Q?jVO0GflbvsGt4ReqKJOnTJ9XikwsJEbl7nWF/0dTcWzmWR6LF1yk4g0hXdeg?=
 =?us-ascii?Q?RYvW1BJ/VYxIFNz9GNaQ6XCwO5yVODb1Da8RSrtz1XCCIcUyTIeSTKtWLQwh?=
 =?us-ascii?Q?i4g1EX9VueDGjMeDlaWs2HODGycXUh6Cj5DglMuR+B3fPLLJqzOTayI6yShl?=
 =?us-ascii?Q?KqTqfyAmnWUV4mO30CsXVrnML7Ry0Mp4NtPlLIq7S5wQ9A+ojH1gSiokqgda?=
 =?us-ascii?Q?qNitu+SfiLv6BQr7VY5Kgewg1oiHdxKBPqNFGLWr7Ko8f6UH23Qs8CgGdIOG?=
 =?us-ascii?Q?jUqnBZVwilytZAko0uyqwvSNO/GatWSrP9h41ueBLskLkY+AqxzL+Ln7v1mH?=
 =?us-ascii?Q?AMURNX2aovqBG7k8jSkqBFJyKroHqQnD55CMZ1l4u2qCiqO+2PmcT/dNjUnO?=
 =?us-ascii?Q?JePx+HAUcSuVkQ57nmmGNeWOT4ao7pFp23DUAddNiluTIagmaZmh2JLAusSr?=
 =?us-ascii?Q?bRdIlOh96iA+hhsWWnxl6twi6tNhmyhYJaJ2dQ4WsX40FDp2GGfWY7yFgzkv?=
 =?us-ascii?Q?/6iOz0ppT4MGFbtB1slWImvZvBJmjrU5QoDFfoD/C5UqA0L9U8GTAAZwPbLH?=
 =?us-ascii?Q?caBhoXPLPaAzFth7UNZ4ACyKgXL6PkRRslV8qjswUtXBtl9CphqozDWFiMKf?=
 =?us-ascii?Q?xxH8k1WrW8eEHDaSHKUy83/qz24S31Azn4TbRyC5yCHpqKECEUlQN4tcZnhh?=
 =?us-ascii?Q?u2R94kmD4Q0sf3CN2uPl48np8PUHFQlDzLmmoiK+WXu9Qp2J32DunzO5Uzgd?=
 =?us-ascii?Q?Wrsh+syQelwt5bLvY0nOUqPaMPh0Bzu80kpB8JSLr5pRgpcJe2xWFLzOptiV?=
 =?us-ascii?Q?i8x10xn1HCLtu+Y/RojqbquX6vfZmWrvmaCsDIEUQCjs4921GSVE070/MCoT?=
 =?us-ascii?Q?yrjnBTKrWBnGzFCcDJ9YjVtfvIdLAUvXEmbsbx3RrYprXfgZWktoZQKw4hd1?=
 =?us-ascii?Q?lgUrlQDgqlu7IBh02o/Yq04bp4VvDRI1MOivkQVEbz5AOeC8zi6K0UfrSmnq?=
 =?us-ascii?Q?1MOI/vd7OFVTFQVkuYAlnWUpnISRyghqaz+YvWMNjtg9SXKLvVQ9JSjeNVse?=
 =?us-ascii?Q?EihMuB1pBI1izfZJlWt75ljuOm3wEmWzptZb2vzRdvmpC+JsEauVES+4DtyH?=
 =?us-ascii?Q?zRgwCVRAsw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5676.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d7c2f42-8bc4-491f-da97-08da390a7b7e
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 20:10:41.0245
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PeOD3+TaqEPzzO8ZAiMa569GqT76ThsyhKdCcvS0jKqeB/Zk9iQ6HbO++2d934nNdxv+ZL8xauI0TRzsKpY2+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5713
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The errors on the APMT* identifiers are due to the missing ACPI patch, whic=
h was
submitted on different series: https://lkml.org/lkml/fancy/2022/4/19/1395.
Sudeep, could you please suggest if I need to combine ACPI and driver patch=
es
into a single patch series ?

I will fix the warning on 'level' usage on the next version.

Regards,
Besar

> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: Wednesday, May 18, 2022 2:16 AM
> To: Besar Wicaksono <bwicaksono@nvidia.com>; robin.murphy@arm.com;
> catalin.marinas@arm.com; will@kernel.org; mark.rutland@arm.com
> Cc: llvm@lists.linux.dev; kbuild-all@lists.01.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> tegra@vger.kernel.org; sudeep.holla@arm.com;
> thanu.rangarajan@arm.com; Michael.Williams@arm.com;
> suzuki.poulose@arm.com; Thierry Reding <treding@nvidia.com>; Jonathan
> Hunter <jonathanh@nvidia.com>; Vikram Sethi <vsethi@nvidia.com>; Besar
> Wicaksono <bwicaksono@nvidia.com>
> Subject: Re: [PATCH v2 1/2] perf: coresight_pmu: Add support for ARM
> CoreSight PMU driver
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> Hi Besar,
>=20
> Thank you for the patch! Perhaps something to improve:
>=20
> [auto build test WARNING on arm64/for-next/core]
> [also build test WARNING on soc/for-next linus/master v5.18-rc7 next-
> 20220517]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>=20
> url:    https://github.com/intel-lab-lkp/linux/commits/Besar-Wicaksono/pe=
rf-
> coresight_pmu-Add-support-for-ARM-CoreSight-PMU-driver/20220516-
> 013131
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git f=
or-
> next/core
> config: arm64-allyesconfig (https://download.01.org/0day-
> ci/archive/20220518/202205181534.wuyBFt9d-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
> 853fa8ee225edf2d0de94b0dcbd31bea916e825e)
> reproduce (this is a W=3D1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-
> tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm64 cross compiling tool for clang build
>         # apt-get install binutils-aarch64-linux-gnu
>         # https://github.com/intel-lab-
> lkp/linux/commit/79f30980a7a91e6bbe7430206e4e46fa8134cfa9
>         git remote add linux-review https://github.com/intel-lab-lkp/linu=
x
>         git fetch --no-tags linux-review Besar-Wicaksono/perf-coresight_p=
mu-
> Add-support-for-ARM-CoreSight-PMU-driver/20220516-013131
>         git checkout 79f30980a7a91e6bbe7430206e4e46fa8134cfa9
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross
> W=3D1 O=3Dbuild_dir ARCH=3Darm64 SHELL=3D/bin/bash
> drivers/media/platform/qcom/venus/ drivers/perf/coresight_pmu/
> drivers/rtc/
>=20
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>=20
> All warnings (new ones prefixed by >>):
>=20
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:165:49: error:
> incomplete definition of type 'struct acpi_apmt_node'
>            return CHECK_APMT_FLAG(coresight_pmu->apmt_node->flags,
> ATOMIC, SUPP);
>                                   ~~~~~~~~~~~~~~~~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:129:4: note: expanded
> from macro 'CHECK_APMT_FLAG'
>            ((flags & (ACPI_APMT_FLAGS_ ## f)) =3D=3D (ACPI_APMT_FLAGS_ ##=
 f ##
> _ ## v))
>              ^~~~~
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:165:9: error: use of
> undeclared identifier 'ACPI_APMT_FLAGS_ATOMIC'
>            return CHECK_APMT_FLAG(coresight_pmu->apmt_node->flags,
> ATOMIC, SUPP);
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:129:13: note: expanded
> from macro 'CHECK_APMT_FLAG'
>            ((flags & (ACPI_APMT_FLAGS_ ## f)) =3D=3D (ACPI_APMT_FLAGS_ ##=
 f ##
> _ ## v))
>                       ^
>    <scratch space>:61:1: note: expanded from here
>    ACPI_APMT_FLAGS_ATOMIC
>    ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:165:9: error: use of
> undeclared identifier 'ACPI_APMT_FLAGS_ATOMIC_SUPP'
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:129:41: note: expanded
> from macro 'CHECK_APMT_FLAG'
>            ((flags & (ACPI_APMT_FLAGS_ ## f)) =3D=3D (ACPI_APMT_FLAGS_ ##=
 f ##
> _ ## v))
>                                                   ^
>    <scratch space>:64:1: note: expanded from here
>    ACPI_APMT_FLAGS_ATOMIC_SUPP
>    ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:369:13: error:
> incomplete definition of type 'struct acpi_apmt_node'
>                    (apmt_node->impl_id) ? apmt_node->impl_id :
>                     ~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:369:35: error:
> incomplete definition of type 'struct acpi_apmt_node'
>                    (apmt_node->impl_id) ? apmt_node->impl_id :
>                                           ~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:894:58: error:
> incomplete definition of type 'struct acpi_apmt_node'
>                    devm_kasprintf(dev, GFP_KERNEL, PMUNAME "%u", apmt_nod=
e-
> >id);
>                                                                  ~~~~~~~~=
~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:920:31: error:
> incomplete definition of type 'struct acpi_apmt_node'
>            if (CHECK_APMT_FLAG(apmt_node->flags, DUAL_PAGE, SUPP)) {
>                                ~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:129:4: note: expanded
> from macro 'CHECK_APMT_FLAG'
>            ((flags & (ACPI_APMT_FLAGS_ ## f)) =3D=3D (ACPI_APMT_FLAGS_ ##=
 f ##
> _ ## v))
>              ^~~~~
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:920:6: error: use of
> undeclared identifier 'ACPI_APMT_FLAGS_DUAL_PAGE'
>            if (CHECK_APMT_FLAG(apmt_node->flags, DUAL_PAGE, SUPP)) {
>                ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:129:13: note: expanded
> from macro 'CHECK_APMT_FLAG'
>            ((flags & (ACPI_APMT_FLAGS_ ## f)) =3D=3D (ACPI_APMT_FLAGS_ ##=
 f ##
> _ ## v))
>                       ^
>    <scratch space>:60:1: note: expanded from here
>    ACPI_APMT_FLAGS_DUAL_PAGE
>    ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:920:6: error: use of
> undeclared identifier 'ACPI_APMT_FLAGS_DUAL_PAGE_SUPP'
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:129:41: note: expanded
> from macro 'CHECK_APMT_FLAG'
>            ((flags & (ACPI_APMT_FLAGS_ ## f)) =3D=3D (ACPI_APMT_FLAGS_ ##=
 f ##
> _ ## v))
>                                                   ^
>    <scratch space>:63:1: note: expanded from here
>    ACPI_APMT_FLAGS_DUAL_PAGE_SUPP
>    ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:1028:15: error:
> incomplete definition of type 'struct acpi_apmt_node'
>            if (apmt_node->ovflw_irq =3D=3D 0)
>                ~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
> >> drivers/perf/coresight_pmu/arm_coresight_pmu.c:1053:6: warning:
> variable 'level' set but not used [-Wunused-but-set-variable]
>            int level =3D 0;
>                ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:1079:27: error:
> incomplete definition of type 'struct acpi_apmt_node'
>            affinity_flag =3D apmt_node->flags & ACPI_APMT_FLAGS_AFFINITY;
>                            ~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:1079:37: error: use of
> undeclared identifier 'ACPI_APMT_FLAGS_AFFINITY'
>            affinity_flag =3D apmt_node->flags & ACPI_APMT_FLAGS_AFFINITY;
>                                               ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:1081:23: error: use of
> undeclared identifier 'ACPI_APMT_FLAGS_AFFINITY_PROC'
>            if (affinity_flag =3D=3D ACPI_APMT_FLAGS_AFFINITY_PROC) {
>                                 ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:1083:17: error:
> incomplete definition of type 'struct acpi_apmt_node'
>                            if (apmt_node->proc_affinity =3D=3D
>                                ~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.c:1093:23: error:
> incomplete definition of type 'struct acpi_apmt_node'
>                                        cpu, apmt_node->proc_affinity))
>                                             ~~~~~~~~~^
>    drivers/perf/coresight_pmu/arm_coresight_pmu.h:116:9: note: forward
> declaration of 'struct acpi_apmt_node'
>            struct acpi_apmt_node *apmt_node;
>                   ^
>    1 warning and 15 errors generated.
>=20
>=20
> vim +/level +1053 drivers/perf/coresight_pmu/arm_coresight_pmu.c
>=20
>   1047
>   1048  static inline int coresight_pmu_find_cpu_container(int cpu, u32
> container_uid)
>   1049  {
>   1050          u32 acpi_uid;
>   1051          struct device *cpu_dev =3D get_cpu_device(cpu);
>   1052          struct acpi_device *acpi_dev =3D ACPI_COMPANION(cpu_dev);
> > 1053          int level =3D 0;
>   1054
>   1055          if (!cpu_dev)
>   1056                  return -ENODEV;
>   1057
>   1058          while (acpi_dev) {
>   1059                  if (!strcmp(acpi_device_hid(acpi_dev),
>   1060                              ACPI_PROCESSOR_CONTAINER_HID) &&
>   1061                      !kstrtouint(acpi_device_uid(acpi_dev), 0, &ac=
pi_uid) &&
>   1062                      acpi_uid =3D=3D container_uid)
>   1063                          return 0;
>   1064
>   1065                  acpi_dev =3D acpi_dev->parent;
>   1066                  level++;
>   1067          }
>   1068
>   1069          return -ENODEV;
>   1070  }
>   1071
>=20
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp