Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220501103520.111561-2-krzysztof.kozlowski@linaro.org>
References: <20220501103520.111561-1-krzysztof.kozlowski@linaro.org> <20220501103520.111561-2-krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 2/8] firmware: qcom_scm-legacy: correct kerneldoc
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Date:   Wed, 18 May 2022 17:03:49 -0700
User-Agent: alot/0.10
Message-Id: <20220519000350.DD5C0C385A9@smtp.kernel.org>
Precedence: bulk

Quoting Krzysztof Kozlowski (2022-05-01 03:35:14)
> diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom_s=
cm-legacy.c
> index 1829ba220576..7854af4abc62 100644
> --- a/drivers/firmware/qcom_scm-legacy.c
> +++ b/drivers/firmware/qcom_scm-legacy.c
> @@ -120,6 +120,9 @@ static void __scm_legacy_do(const struct arm_smccc_ar=
gs *smc,
>  /**
>   * scm_legacy_call() - Sends a command to the SCM and waits for the comm=
and to
>   * finish processing.
> + * @dev:       device
> + * @desc:      descriptor structure containing arguments and return valu=
es
> + * @res:        results from SMC/HVC call

I think only SMC call is possible so drop HVC to not be confusing.

>   *
>   * A note on cache maintenance:
>   * Note that any buffers that are expected to be accessed by the secure =
world