Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220501103520.111561-6-krzysztof.kozlowski@linaro.org>
References: <20220501103520.111561-1-krzysztof.kozlowski@linaro.org> <20220501103520.111561-6-krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 6/8] rpmsg: qcom: correct kerneldoc
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Date:   Wed, 18 May 2022 17:11:52 -0700
User-Agent: alot/0.10
Message-Id: <20220519001154.A64A2C385AA@smtp.kernel.org>
Precedence: bulk

Quoting Krzysztof Kozlowski (2022-05-01 03:35:18)
> Correct kerneldoc warnings like:
>=20
>   drivers/rpmsg/qcom_glink_ssr.c:45:
>     warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_=
CLEANUP() instead
>=20
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

>  drivers/rpmsg/qcom_glink_ssr.c | 2 +-
>  drivers/rpmsg/qcom_smd.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ss=
r.c
> index dea929c6045d..776d64446879 100644
> --- a/drivers/rpmsg/qcom_glink_ssr.c
> +++ b/drivers/rpmsg/qcom_glink_ssr.c
> @@ -39,7 +39,7 @@ struct cleanup_done_msg {
>         __le32 seq_num;
>  };
> =20
> -/**
> +/*
>   * G-Link SSR protocol commands
>   */
>  #define GLINK_SSR_DO_CLEANUP   0
> diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
> index 7c8c29f6c91d..e7e49d972d36 100644
> --- a/drivers/rpmsg/qcom_smd.c
> +++ b/drivers/rpmsg/qcom_smd.c
> @@ -729,7 +729,7 @@ static int qcom_smd_write_fifo(struct qcom_smd_channe=
l *channel,
>  }
> =20
>  /**
> - * qcom_smd_send - write data to smd channel
> + * __qcom_smd_send - write data to smd channel
>   * @channel:   channel handle
>   * @data:      buffer of data to write
>   * @len:       number of bytes to write

Not part of this patch but it says "flag to indicate if write has ca
wait" and I wonder what "ca" means.