Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ef6905f-563d-2361-36fb-d6f56a5d6353@huawei.com>
Date:   Thu, 19 May 2022 14:22:41 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH -next v2] fs-verity: Use struct_size() helper in
 enable_verity()
To:     Eric Biggers <ebiggers@kernel.org>
CC:     <tytso@mit.edu>, <linux-fscrypt@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220519022450.2434483-1-chris.zjh@huawei.com>
 <YoW0HG+Nbg681yWL@sol.localdomain> <YoW25wrIAiRVifMi@sol.localdomain>
 <e030eaf6-0b6b-7685-c5b6-fd0b57aea600@huawei.com>
 <YoXGEckfSNWKj2oT@sol.localdomain>
From:   "zhangjianhua (E)" <chris.zjh@huawei.com>
In-Reply-To: <YoXGEckfSNWKj2oT@sol.localdomain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thanks, I will do more work about sparse and maybe find some answers.


Zhang Jianhua

在 2022/5/19 12:22, Eric Biggers 写道:
> [Please use reply all, not just reply!]
>
> On Thu, May 19, 2022 at 11:54:48AM +0800, zhangjianhua (E) wrote:
>> Hi Eric
>>
>> The warnings in commit message are from the build log in Jan 2022, and I
>> find these sizeof are still here, so I submit
>>
>> these two patches. I build the kernel just now and encounter the same
>> situation with you, there are lots of warnings.
>>
>> Maybe you are right, there should be some mechanism to solve this problem
>> completely.
>>
>>
> I've updated the commit message and applied this patch, but not the other one,
> as the other one wasn't actually dealing with a variable length which made it
> pretty much pointless, as I mentioned.
>
> If you'd like to look into making sparse enable this warning by default, I'd
> certainly encourage you to do so.  But it looks like the warning itself could
> use some more work.  It probably should only warn if the
> sizeof(struct_with_flexible_array) is actually being added to another value, and
> where that value is not a compile-time constant.
>
> - Eric
> .