Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1238757iob; Thu, 19 May 2022 02:16:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz21Xp5yePRscSattNz+0O/nY+DkMzxEXvW0W8E3RFZYg1RoPYJUplBOzBktgwMPWwNAq1F X-Received: by 2002:a63:ce56:0:b0:3db:1c56:1960 with SMTP id r22-20020a63ce56000000b003db1c561960mr3134213pgi.305.1652951777449; Thu, 19 May 2022 02:16:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652951777; cv=none; d=google.com; s=arc-20160816; b=nzMRNXziSRSC1UhLBk5wfRwU4wp5/hQBAjUCaTi32SHzq3oYg8sKUzqbfl+jySDvv/ 48UabEU1pE+hgpT9gjMFDN1NTla0XXVqRELSxuHo0X+HL4DSDRkJNs44RiRpLiy9Y0Ba s2/o7vI4+eG9EgmlXN+S3C7Itu5XKsze4TQk1AkMe4xgt+On0Y66V7fObxaWC6ImRMI4 pINB0itqtL//KzqCPEPTdWDcvZY030WdCmzzgSXyGEbCbukFgpuH1ML6WsDELZ7r7yDi wObQGRcYTObHtYKtXOj8kp3qApubtL8Wrh7qryA140rc6vCjh3ImSBOUODvl2KlLzp/Q 1xjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c77uzmu2TXpLltRnApNzAkuooRra7/UmN/A1/ovIrcE=; b=LXwCK9kyhmd5GgU0DhZxTXwTrmII77BSZLM3pqc5qqbaVFFBWd3/062/gyKAsoLEoh PD5S0WlatL7Iws/kD/OW0wiVH9iTmlx7JsY8QU6FbDyMUJNxkYavEbS+9ookdfhr8TdC fsQ1peSTuDIf5OLkrAsKkDHySbfexbIbBwQaUSX3p2qumgUOwJYVHfJU3r70IngBQa7s Tg1E8S6KXWnIr8XiodjpgHakkqY3AePMhOYUOY+ZT5kmwlDute69TOBCUI6I7p+Wguhl nnVfsglh1d30ch/rRgBcq3O/Kdlb4/xmP5Mey7EsY54WM0/Rw9CeNlHXptGQvDLNa8S/ YbOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ixqcTcwA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020a634457000000b003f655829a2csi247485pgk.346.2022.05.19.02.16.03; Thu, 19 May 2022 02:16:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ixqcTcwA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233032AbiESDGM (ORCPT + 99 others); Wed, 18 May 2022 23:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233049AbiESDGJ (ORCPT ); Wed, 18 May 2022 23:06:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1456B3CFEE; Wed, 18 May 2022 20:06:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF0616190E; Thu, 19 May 2022 03:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1E6BC385A5; Thu, 19 May 2022 03:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652929566; bh=9qOFUq/lpbubY4Pgg4LomrYbZgcFce8ILsuHL2uzdII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ixqcTcwA1w3QGsa/sk11i4rBPAlGlqHe6ktmLVbib0LWYumcp2whX96lrLfL5VC9l /JoBjtxhevuXQTq7cUmAhF/9OY8FqQCPx0SRakFwpX337p7nfNkZrx/Wbf6OOwqK42 Smo1YLswuM7fFz6XG4kC9tgtnz6j3qWxB/6kzlfJ/NnXus2z2MOlUrjavxBl8jqbn1 9lS4H9pWMgx5shhdQfpesaOH6oWrqm6pr9fPrF8o9wVc0cer2M+ti6WCxZB7Zm0nD7 HSpPrHSuT72w91qt/6E4id0VE+ADR7xA+AbdGW8hyxsfoEoiMGjXOIqxZcq8D5PLuQ E5Gz5BXOUpfpA== Date: Wed, 18 May 2022 20:06:04 -0700 From: Eric Biggers To: Zhang Jianhua Cc: tytso@mit.edu, linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v2] fs-verity: Use struct_size() helper in enable_verity() Message-ID: References: <20220519022450.2434483-1-chris.zjh@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220519022450.2434483-1-chris.zjh@huawei.com> X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2022 at 10:24:50AM +0800, Zhang Jianhua wrote: > Also, address the following sparse warning: > fs/verity/enable.c:205:28: warning: using sizeof on a flexible structure How can I reproduce this warning? I am using the latest version of sparse, and I don't see any of these warnings you're reporting. $ sparse --version v0.6.4 $ make C=2 fs/verity/ CHECK scripts/mod/empty.c CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh DESCEND objtool CHECK fs/verity/enable.c CHECK fs/verity/hash_algs.c CHECK fs/verity/init.c CHECK fs/verity/measure.c CHECK fs/verity/open.c CHECK fs/verity/read_metadata.c CHECK fs/verity/verify.c CHECK fs/verity/signature.c - Eric