Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3976cf6a-0b40-4763-a233-eacf93925d53@gmx.de>
Date:   Thu, 19 May 2022 11:14:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] video: fbdev: Fix refcount leak in clcdfb_of_vram_setup
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Pawel Moll <pawel.moll@arm.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220512115913.48685-1-linmq006@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220512115913.48685-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 5/12/22 13:59, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: d10715be03bd ("video: ARM CLCD: Add DT support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

applied to the fbdev tree.
Thanks!
Helge

> ---
>  drivers/video/fbdev/amba-clcd.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-=
clcd.c
> index 9ec969e136bf..8080116aea84 100644
> --- a/drivers/video/fbdev/amba-clcd.c
> +++ b/drivers/video/fbdev/amba-clcd.c
> @@ -758,12 +758,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb=
)
>  		return -ENODEV;
>
>  	fb->fb.screen_base =3D of_iomap(memory, 0);
> -	if (!fb->fb.screen_base)
> +	if (!fb->fb.screen_base) {
> +		of_node_put(memory);
>  		return -ENOMEM;
> +	}
>
>  	fb->fb.fix.smem_start =3D of_translate_address(memory,
>  			of_get_address(memory, 0, &size, NULL));
>  	fb->fb.fix.smem_len =3D size;
> +	of_node_put(memory);
>
>  	return 0;
>  }