Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bf122ee3-1af8-b4d9-bf1d-828bec24deae@gmx.de>
Date:   Thu, 19 May 2022 11:20:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] omapfb: simplify the return expression of
 dsi_init_pll_data()
Content-Language: en-US
To:     cgel.zte@gmail.com
Cc:     linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220429054751.3851851-1-chi.minghao@zte.com.cn>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220429054751.3851851-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 4/29/22 07:47, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

I've applied both of your omapfb patches to the fbdev tree.

Thanks!
Helge


> ---
>  drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/v=
ideo/fbdev/omap2/omapfb/dss/hdmi_pll.c
> index c5f89129dcdd..531b36d2232b 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> @@ -173,7 +173,6 @@ static int dsi_init_pll_data(struct platform_device =
*pdev, struct hdmi_pll_data
>  {
>  	struct dss_pll *pll =3D &hpll->pll;
>  	struct clk *clk;
> -	int r;
>
>  	clk =3D devm_clk_get(&pdev->dev, "sys_clk");
>  	if (IS_ERR(clk)) {
> @@ -203,12 +202,7 @@ static int dsi_init_pll_data(struct platform_device=
 *pdev, struct hdmi_pll_data
>  	}
>
>  	pll->ops =3D &dsi_pll_ops;
> -
> -	r =3D dss_pll_register(pll);
> -	if (r)
> -		return r;
> -
> -	return 0;
> +	return dss_pll_register(pll);
>  }
>
>  int hdmi_pll_init(struct platform_device *pdev, struct hdmi_pll_data *p=
ll,