Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chanho Park" <chanho61.park@samsung.com>
To:     <daejun7.park@samsung.com>,
        "'ALIM AKHTAR'" <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
        <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <beanhuo@micron.com>, <bvanassche@acm.org>
Cc:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <252651381.41652940482659.JavaMail.epsvc@epcpadp4>
Subject: RE: [PATCH] scsi: ufs: Fix referencing invalid rsp field
Date:   Thu, 19 May 2022 15:46:32 +0900
Message-ID: <000001d86b4c$2d460640$87d212c0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQGxVZvV+SXqOOTuFkA2CfROecP6UgKFUAa1rV/B96A=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20220519060529epcms2p8941ce10ed8cfb50c142140f1f69f8612@epcms2p8>
        <252651381.41652940482659.JavaMail.epsvc@epcpadp4>
Precedence: bulk

> This is a patch for fixing referencing sense data when it is invalid.
> When the length of the data segment is 0, there is no valid information in
> the rsp field, so ufshpb_rsp_upiu() is returned without additional
> operation.
> 

You should put a proper fix tag to be applied the corresponding stable tree.
See https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Fixes: 4b5f49079c52 ("scsi: ufs: ufshpb: L2P map management for HPB read")

Best Regards,
Chanho Park

> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
> ---
>  drivers/scsi/ufs/ufshpb.c | 19 +++++++------------
>  1 file changed, 7 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index
> f1f65383e97d..8882b47f76d3 100644
> --- a/drivers/scsi/ufs/ufshpb.c
> +++ b/drivers/scsi/ufs/ufshpb.c
> @@ -1304,6 +1304,13 @@ void ufshpb_rsp_upiu(struct ufs_hba *hba, struct
> ufshcd_lrb *lrbp)
>  	struct utp_hpb_rsp *rsp_field = &lrbp->ucd_rsp_ptr->hr;
>  	int data_seg_len;
> 
> +	data_seg_len = be32_to_cpu(lrbp->ucd_rsp_ptr->header.dword_2)
> +		& MASK_RSP_UPIU_DATA_SEG_LEN;
> +
> +	/* If data segment length is zero, rsp_field is not valid */
> +	if (!data_seg_len)
> +		return;
> +
>  	if (unlikely(lrbp->lun != rsp_field->lun)) {
>  		struct scsi_device *sdev;
>  		bool found = false;
> @@ -1338,18 +1345,6 @@ void ufshpb_rsp_upiu(struct ufs_hba *hba, struct
> ufshcd_lrb *lrbp)
>  		return;
>  	}
> 
> -	data_seg_len = be32_to_cpu(lrbp->ucd_rsp_ptr->header.dword_2)
> -		& MASK_RSP_UPIU_DATA_SEG_LEN;
> -
> -	/* To flush remained rsp_list, we queue the map_work task */
> -	if (!data_seg_len) {
> -		if (!ufshpb_is_general_lun(hpb->lun))
> -			return;
> -
> -		ufshpb_kick_map_work(hpb);
> -		return;
> -	}
> -
>  	BUILD_BUG_ON(sizeof(struct utp_hpb_rsp) != UTP_HPB_RSP_SIZE);
> 
>  	if (!ufshpb_is_hpb_rsp_valid(hba, lrbp, rsp_field))
> --
> 2.25.1
>