Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <57184edb-8a04-b4bd-969b-bca152375d86@marcan.st>
Date:   Thu, 19 May 2022 17:29:39 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 0/8] Add hardware prefetch control driver for A64FX and
 x86
Content-Language: es-ES
To:     Kohei Tarumizu <tarumizu.kohei@fujitsu.com>,
        catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, gregkh@linuxfoundation.org,
        rafael@kernel.org, mchehab+huawei@kernel.org, eugenis@google.com,
        tony.luck@intel.com, pcc@google.com, peterz@infradead.org,
        marcos@orca.pet, conor.dooley@microchip.com,
        nicolas.ferre@microchip.com, linus.walleij@linaro.org,
        arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20220518063032.2377351-1-tarumizu.kohei@fujitsu.com>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <20220518063032.2377351-1-tarumizu.kohei@fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/05/2022 15.30, Kohei Tarumizu wrote:
> This patch series add sysfs interface to control CPU's hardware
> prefetch behavior for performance tuning from userspace for the
> processor A64FX and x86 (on supported CPU).
> 

[snip]

> In pattern A, a change of dist at L1 has a larger effect. On the other
> hand, in pattern B, the change of dist at L2 has a larger effect.
> As described above, the optimal dist combination depends on the
> characteristics of the application. Therefore, such a sysfs interface
> is useful for performance tuning.

If this is something to be tuned for specific applications, shouldn't it
be a prctl or similar and part of process context, so different
applications can use different settings (or even a single application
depending on what it's doing)? Especially if writing those sysregs/MSRs
is cheap.

In particular, configuring things separately for different cores feels
strange. You'd then have to pin applications to specific cores to get
the benefits, and wouldn't be able to optimize for multiple applications
running simultaneously that need different prefetch behavior if they
share cores.

-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub