Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 May 2022 16:03:53 +0200
From:   =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Herve Codina <herve.codina@bootlin.com>,
        =?UTF-8?B?TWlxdcOobA==?= Raynal <miquel.raynal@bootlin.com>,
        Milan Stevanovic <milan.stevanovic@se.com>,
        Jimmy Lalande <jimmy.lalande@se.com>,
        Pascal Eberhard <pascal.eberhard@se.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
        Jean-Pierre Geslin <jean-pierre.geslin@non.se.com>,
        Phil Edworthy <phil.edworthy@renesas.com>
Subject: Re: [PATCH net-next v4 06/12] net: dsa: rzn1-a5psw: add Renesas
 RZ/N1 advanced 5 port switch driver
Message-ID: <20220519160353.12ee7463@fixe.home>
In-Reply-To: <20220511093638.kc32n6ldtaqfwupi@skbuf>
References: <20220509131900.7840-1-clement.leger@bootlin.com>
        <20220509131900.7840-7-clement.leger@bootlin.com>
        <20220509160813.stfqb4c2houmfn2g@skbuf>
        <20220510103458.381aaee2@xps-bootlin>
        <20220511093638.kc32n6ldtaqfwupi@skbuf>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Le Wed, 11 May 2022 12:36:38 +0300,
Vladimir Oltean <olteanv@gmail.com> a =C3=A9crit :

> On Tue, May 10, 2022 at 10:34:58AM +0200, Cl=C3=A9ment L=C3=A9ger wrote:
> > > By the way, does this switch pass
> > > tools/testing/selftests/drivers/net/dsa/no_forwarding.sh? =20
> >=20
> > Unfortunately, the board I have only has 2 ports availables and thus, I
> > can only test one bridge or two separated ports at a time... I *should*
> > receive a 4 ports one in a near future but that not yet sure. =20
>=20
> 2 switch ports or 2 ports in total? h1 and h2 can be non-switch ports
> (should work with USB-Ethernet adapters etc).

Ok, I finally got the tests running. They seems to work for the
standalone variant.

TEST: Standalone switch ports: Unicast non-IP untagged              [ OK ]
TEST: Standalone switch ports: Multicast non-IP untagged            [ OK ]
TEST: Standalone switch ports: Broadcast non-IP untagged            [ OK ]
TEST: Standalone switch ports: Unicast IPv4 untagged                [ OK ]
TEST: Standalone switch ports: Multicast IPv4 untagged              [ OK ]
TEST: Standalone switch ports: Unicast IPv6 untagged                [ OK ]
TEST: Standalone switch ports: Multicast IPv6 untagged              [ OK ]

I disabled tests two_bridges and one_bridge_two_pvids since the
switch driver does only support 1 bridge and do not have vlan support
yet.

I also ran ./test_bridge_fdb_stress.sh which did reveal some sleep in
spin_lock() issue due to poll_io_timeout() being used. I switch the FDB
lock to use a mutex instead of a spinlock.

--=20
Cl=C3=A9ment L=C3=A9ger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com