Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9b6a240-3af2-e921-6c59-40bf169f423f@kernel.org>
Date:   Thu, 19 May 2022 07:41:08 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 1/2] i2c: designware: introduce a custom scl recovery for
 SoCFPGA platforms
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
        robh+dt@kernel.org, krzk+dt@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220518202217.85803-1-dinguyen@kernel.org>
 <YoYaA5iTin3rzuob@smile.fi.intel.com>
From:   Dinh Nguyen <dinguyen@kernel.org>
In-Reply-To: <YoYaA5iTin3rzuob@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/19/22 05:20, Andy Shevchenko wrote:
> On Wed, May 18, 2022 at 03:22:16PM -0500, Dinh Nguyen wrote:
>> The I2C pins on the SoCFPGA platforms do not go through a GPIO module,
>> thus cannot be recovered by the default method of by doing a GPIO access.
>> Only a reset of the I2C IP block can a recovery be successful.
> 
> ...
> 
>>   #define MODEL_BAIKAL_BT1	BIT(9)
>>   #define MODEL_AMD_NAVI_GPU	BIT(10)
>> +#define MODEL_SOCFPGA		BIT(11)
> 
> ...
> 
>> -#define MODEL_MASK		GENMASK(11, 8)
> 
>> +#define MODEL_MASK		GENMASK(12, 8)
> 
> Why this change is made?

Sorry, mistake here..will remove.

> 
> ...
> 
>> +	switch (dev->flags & MODEL_MASK) {
>> +	case MODEL_SOCFPGA:
>> +		rinfo->recover_bus = i2c_custom_scl_recovery;
> 
> _custom_ is too broad, use exact name, i.e.
> 
> 	i2c_socfpga_scl_recovery
> 

Ok

>> +		break;
>> +	default:
>> +		rinfo->recover_bus = i2c_generic_scl_recovery;
>> +		break;
>> +	}
> 
> ...
> 
>> +	{ .compatible = "intel,socfpga-i2c", .data = (void *)MODEL_SOCFPGA },
> 
>> +
> 
> Stray change.

Will fix...

Thanks for the review!

Dinh
>