Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d777d12c-7fd2-07d8-60ee-d2dc8f73f6c7@metafoo.de>
Date:   Thu, 19 May 2022 11:58:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] iio: trigger: sysfs: fix use-after-free on remove
Content-Language: en-US
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        Jonathan Cameron <jic23@kernel.org>
Cc:     kernel@axis.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220519091925.1053897-1-vincent.whitchurch@axis.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
In-Reply-To: <20220519091925.1053897-1-vincent.whitchurch@axis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/19/22 11:19, Vincent Whitchurch wrote:
> [...]
>   
>
> Fixes: e64e7d5c8c86e ("iio:trigger:sysfs Move out of staging.")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

Thanks for the patch!

Strictly speaking the Fixes: should be

f38bc926d022 ("staging:iio:sysfs-trigger: Use irq_work to properly 
active trigger")


Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

> ---
>   drivers/iio/trigger/iio-trig-sysfs.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/trigger/iio-trig-sysfs.c b/drivers/iio/trigger/iio-trig-sysfs.c
> index 2a4b75897910..3d911c24b265 100644
> --- a/drivers/iio/trigger/iio-trig-sysfs.c
> +++ b/drivers/iio/trigger/iio-trig-sysfs.c
> @@ -191,6 +191,7 @@ static int iio_sysfs_trigger_remove(int id)
>   	}
>   
>   	iio_trigger_unregister(t->trig);
> +	irq_work_sync(&t->work);
>   	iio_trigger_free(t->trig);
>   
>   	list_del(&t->l);