Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20f17f64-88cb-4e80-07c1-85cb96c83619@windriver.com>
Date:   Thu, 19 May 2022 16:22:04 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To:     dchinner@redhat.com, amir73il@gmail.com,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
From:   He Zhe <zhe.he@windriver.com>
Subject: warning for EOPNOTSUPP vfs_copy_file_range
Cc:     He Zhe <Zhe.He@windriver.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mjh4ZWYrUUdmNUFnemhxVHF0TUxJdGx5L1ROZWQ4SDBySnZyZyt0ejJhYlhS?=
 =?utf-8?B?K2JBNVY5djlRMFdwQ1NUNEppb2pWWDNPc3pJRWZvaWpRanVhTTJxaW9yWkpi?=
 =?utf-8?B?by9zbXdRenVLRzBHZm9hRHdaWHpTWVBBTHQ2M3huS0FkMVg5dHN2eGdzYmtO?=
 =?utf-8?B?M1o5UU5YcTdCbjFoQWR6UFJjeEpRVzRXcXNaZGp1T3hKazg1WkI4VkZZSndn?=
 =?utf-8?B?NTRUQUxaMjRFdHJIa09kQkVtRHFLZ3ArS2lBZnZhVmVjbGg0K0EwTVIrOHNq?=
 =?utf-8?B?OXMwdUNFdGplai9KL29hZDFPU3Jta3VaZ0dON2p4aVZ1YURlYkNsWGpMQzJ6?=
 =?utf-8?B?bXdiSy91N1dxUjlsVks0aGJYUi9mOW1lUmY0clFYUVlDVjhqTk9hU21rcnlo?=
 =?utf-8?B?aUJrTFVRQkNIMDg0Nk9XR1RURmJiWTh0ZzRhZlo0ejZEK1VtYThPSndDM1Nh?=
 =?utf-8?B?Qi9JSjNBMzNkYnhkamlHM1hJTklBTGFQMWg0cEd2a1kwYkJSUUhPdVlZanZM?=
 =?utf-8?B?Y2ZaUmVlWWZ2cHIwSXVKc2VraVJxYSsyVHRGd25aOHFVWHFvOGxXNFVTQmdK?=
 =?utf-8?B?L0FJWnUzbzlmSlFteG5LblZFd3JXOStoQlZxQVk1YXVRZzdTdzV4TC9yQ2pS?=
 =?utf-8?B?c3BLNHdsdXBFM0tDMGdESkVsNDdPbHZzYlBlL2FUTDFKUWdNYnNEVzF3dkpp?=
 =?utf-8?B?bituaFVsT01wSzFKNEtpaXg0Rml2VERuSUxUYUFsS25OaG40VlpCZUxJUm10?=
 =?utf-8?B?QTNzM0V5K0hEcE53WTZzTjJRYW5KRDVOVmVjaCtTVlloZkQwZjZkaGxnVDh4?=
 =?utf-8?B?Rmxyc1loazJFNmYwVXVFK01ubERJL0g3MGlIUzFVS2NLOFdXeEVyZzhZQkhn?=
 =?utf-8?B?RE1yVHYxaXREbHFSaTcyYit1bTlaenR1N0hWU2hmVnBuWEZMTEpSaE9xYU1Y?=
 =?utf-8?B?cE9jdnRueEhZcUJsVHB3VWdxdW1FTGR1cERlMFdEWUdud2Nac08zSjdoNHRN?=
 =?utf-8?B?a2dCZGZmclg2T0dPRGlxVjI0MTRxV0Mvc1RDZE5tZ1ZHbmYrRkdlYXZGbU1P?=
 =?utf-8?B?Y0laMU9RMTBKamh5aHoyUEJPM25COTNIZmh6ZElZQXFzNkhyRGZmQ2pDbkp2?=
 =?utf-8?B?R0JabDJ0RU9KcHBleTZYTXg4TElsRmpPZG9EVEl5NGowZ010WUhFMmJFQUd5?=
 =?utf-8?B?d3BabmEyaVFyNVZNQzY5SEZnejlUS1Qra3JnaFE2QUtJTnZubHRqZU9xd0xj?=
 =?utf-8?B?bHkvMm42YjdBanFEVy85dEVtcTk1LzVLSGdiejJEQk1Fbjg2NXZiR0ZmQ3A1?=
 =?utf-8?B?dkwrd2IvMEVIajVLSG4xbnZia0c2ZmRLdGpvYnRPWHBtODBRZkYreVA4MmNk?=
 =?utf-8?B?TUF2NXRUbG5Ta2NheU1HR25yeTF2QTEzRW05eGg0emdiZmJSMzFLa1Z1V29k?=
 =?utf-8?B?M0xuSjNDaDZrNXhXcVFxUTY3SlBDcS9KMmVBQVdSMHcyV2JGZjljMzM1LzJa?=
 =?utf-8?B?MG4ybjRlVVFjdHhFenUva3VSbGZZdjBEMlBqWkdDbnl1Nk9aNTBCYzh1TTFk?=
 =?utf-8?B?Sms1NFpSaURUUEFYdlN5OWtDcWt0TlFkeWJFUHE4S0JNcGVwUnRLRDhZYjJS?=
 =?utf-8?B?eG9LK3l6d0xFT2N0cFNNNmM4eG9JNzJFbUNqbVcwMkhJVm1hUGZCcTc3QUJE?=
 =?utf-8?B?dXZjTnBJazBheXByTmZ3eFhreGI4elVyVytRMGtQR1luendTR3o0Y25uZXp2?=
 =?utf-8?B?UXFMRUpzZkc3N3c2UkVKTFZjU25Zdjh4b2FlQmEyLytHaG1maFFtYlBLQVVp?=
 =?utf-8?B?aDZLbnVwR2hPY3RJaHU2VmE1bEZQTThiM3BnVnNVTGN1YmY4RlMvVDJ3cjk0?=
 =?utf-8?B?VHNjYWxHcWlkY1kwRllGZTdJRkNLQk5LTFZObWNaMFA3eHlRcTVTb3VxbUl2?=
 =?utf-8?B?ZFJqREhwM2RzVkh6S0FIWWQyd1VPSjdPUUFJWnhNemlSUFNMUWdzQVdGbkFK?=
 =?utf-8?B?WlFPcHpaWjBJa2ZhWTZMZG9yQXBNK0VtL1AzWVFManhRV3BPTVBHdnBsWHlS?=
 =?utf-8?B?RmdjeGxnYkVIWll2NWxaWVB6T2p1ZmkxMjlNRTcvK3lidThuK29wSHFSa0ds?=
 =?utf-8?B?amVncElDM3NvVy9kYjhvL1BhTzBNOWtMWnNPMjdaWDFIRGNjTXhjMkFaajZJ?=
 =?utf-8?B?SzR6OWZVWDBJaEZTS2RMbDlFVTM4VnpIV01uRFFGNHFPQVdKbUh0T3dMQThJ?=
 =?utf-8?B?Ull5YjlkaSt1ak9wM2tCY1ptTXR4UDZVdWlkM1dQZHFXVzI5SWhkUEQ5aDJq?=
 =?utf-8?B?cmZlWTVxN1NFMHIwK2FqcXZLZ0ZSa2VON2x4bGNjem8vcFBoVGdkQT09?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa89fa4-6555-4dfa-dd46-08da3970acf9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1358.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 08:22:13.0491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2uQ8v7z1E60kmeH3bRT1psUlBk8WiwLaQ/wud1/i9y42iWof+idFQyCzFzXnLPAL2+//lhuYWV4hDRQQgWxIjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1382
X-Proofpoint-ORIG-GUID: Nd9TybIGQddoGZMGCj4sBBHfs3u4dVlg
X-Proofpoint-GUID: Nd9TybIGQddoGZMGCj4sBBHfs3u4dVlg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-19_01,2022-05-19_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0
 impostorscore=0 bulkscore=0 clxscore=1011 mlxscore=0 malwarescore=0
 mlxlogscore=877 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205190049
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

We are experiencing the following warning from
"WARN_ON_ONCE(ret == -EOPNOTSUPP);" in vfs_copy_file_range, from
64bf5ff58dff ("vfs: no fallback for ->copy_file_range")

# cat /sys/class/net/can0/phys_switch_id

WARNING: CPU: 7 PID: 673 at fs/read_write.c:1516 vfs_copy_file_range+0x380/0x440
Modules linked in: llce_can llce_logger llce_mailbox llce_core sch_fq_codel
openvswitch nsh nf_conncount nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4
CPU: 7 PID: 673 Comm: cat Not tainted 5.15.38-yocto-standard #1
Hardware name: Freescale S32G399A (DT)
pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : vfs_copy_file_range+0x380/0x440
lr : vfs_copy_file_range+0x16c/0x440
sp : ffffffc00e0f3ce0
x29: ffffffc00e0f3ce0 x28: ffffff88157b5a40 x27: 0000000000000000
x26: ffffff8816ac3230 x25: ffffff881c060008 x24: 0000000000001000
x23: 0000000000000000 x22: 0000000000000000 x21: ffffff881cc99540
x20: ffffff881cc9a340 x19: ffffffffffffffa1 x18: ffffffffffffffff
x17: 0000000000000001 x16: 0000adfbb5178cde x15: ffffffc08e0f3647
x14: 0000000000000000 x13: 34613178302f3061 x12: 3178302b636e7973
x11: 0000000000058395 x10: 00000000fd1c5755 x9 : ffffffc008361950
x8 : ffffffc00a7d4d58 x7 : 0000000000000000 x6 : 0000000000000001
x5 : ffffffc009e81000 x4 : ffffffc009e817f8 x3 : 0000000000000000
x2 : 0000000000000000 x1 : ffffff88157b5a40 x0 : ffffffffffffffa1
Call trace:
 vfs_copy_file_range+0x380/0x440
 __do_sys_copy_file_range+0x178/0x3a4
 __arm64_sys_copy_file_range+0x34/0x4c
 invoke_syscall+0x5c/0x130
 el0_svc_common.constprop.0+0x68/0x124
 do_el0_svc+0x50/0xbc
 el0_svc+0x54/0x130
 el0t_64_sync_handler+0xa4/0x130
 el0t_64_sync+0x1a0/0x1a4
cat: /sys/class/net/can0/phys_switch_id: Operation not supported

And we found this is triggered by the following stack. Specifically, all
netdev_ops in CAN drivers we can find now do not have ndo_get_port_parent_id and
ndo_get_devlink_port, which makes phys_switch_id_show return -EOPNOTSUPP all the
way back to vfs_copy_file_range.

phys_switch_id_show+0xf4/0x11c
dev_attr_show+0x2c/0x6c
sysfs_kf_seq_show+0xb8/0x150
kernfs_seq_show+0x38/0x44
seq_read_iter+0x1c4/0x4c0
kernfs_fop_read_iter+0x44/0x50
generic_file_splice_read+0xdc/0x190
do_splice_to+0xa0/0xfc
splice_direct_to_actor+0xc4/0x250
do_splice_direct+0x94/0xe0
vfs_copy_file_range+0x16c/0x440
__do_sys_copy_file_range+0x178/0x3a4
__arm64_sys_copy_file_range+0x34/0x4c
invoke_syscall+0x5c/0x130
el0_svc_common.constprop.0+0x68/0x124
do_el0_svc+0x50/0xbc
el0_svc+0x54/0x130
el0t_64_sync_handler+0xa4/0x130
el0t_64_sync+0x1a0/0x1a4

According to the original commit log, this warning is for operational validity
checks to generic_copy_file_range(). The reading will eventually return as
not supported as printed above. But is this warning still necessary? If so we
might want to remove it to have a cleaner dmesg.


Thanks,
Zhe