Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Eugen Hristev <eugen.hristev@microchip.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-media@vger.kernel.org (open list:MICROCHIP ISC DRIVER),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/Microchip
        (AT91) SoC support), linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] media: atmel: atmel-isc: remove unneeded IS_ERR()
Date:   Thu, 19 May 2022 14:52:33 +0800
Message-Id: <20220519065234.127978-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NfLax/4b98LpVMsvbErVtrHtRMvndIQKW9fObAe7D8Q+r3r3hRusExEaIpLP?=
 =?us-ascii?Q?7WnzxvyAgJ0LLc2dm0V0EqEql9kmvaKm5W7M0x9xVxHgdGllcGxkyD1hnApT?=
 =?us-ascii?Q?lmqttT+4P+0OhujNClJjpD+KwdWqReqhXZyibFQUzHBZk2bkYXeCgl1xg/kd?=
 =?us-ascii?Q?P/E5VVbPkqybN+THmkoO29ai0QHxoemiU5rxEqkiRo87IShA6vj7RDMwLUjd?=
 =?us-ascii?Q?cOuZz4HoFqQ/BJljw1CNkOqbHLki8QsReEaNwQqKgpFugXC7hmEPctKnj9vs?=
 =?us-ascii?Q?u+6TzOMejo+BZU7adL6SY2DT2oNIX+dONrQmGhU7tBCe1WYdaJs0sj8b/X4J?=
 =?us-ascii?Q?DxSVqQzoYJEFtZRQ8ekSUHMuBqKQY5QJ+CUE5xD9Tvu52IrOwxtqAk7s18qQ?=
 =?us-ascii?Q?ZQpRMIXTp5uw8ibr1sC6nXDUQHENX7elcd5SjFrooWkydgzpyaUUED3C8Sw6?=
 =?us-ascii?Q?TtR2r/ZdM03jxuy2MFxvBAQh28iO4JUISOVe3xZbJ6qKOhrBSdd49l3/ug0c?=
 =?us-ascii?Q?ruPoMYGO8t9ktyfvbeuASS7dzRLcJ0KQLvgai55RWcoohC8sHLALxsmHBTO+?=
 =?us-ascii?Q?OojlHwSxrsyehT3wFQFgRATe3eceSlGouDI362ZjLWXgvMLTSzOCh2/p6Xx5?=
 =?us-ascii?Q?FPddsoD9s8NgPXAdWV/8LFGio9syH3n1eachYL63n6DVQyJUlJIm01j3N3qm?=
 =?us-ascii?Q?YSU7WdSAJTERaiCv0eDp5kmxI1zaM2jeS4h+agDi4vyOl+i53U9ZsgjzmjAp?=
 =?us-ascii?Q?KnRIf2ehBCxnRhTOHxK0BuLEdlHxhbtSUWL/zML5f0a2YhWs6cvkKeYDumdP?=
 =?us-ascii?Q?kFJl9Jc7uVgijfBN9ODDX5oqXTm2h7oES+O5HpWP3hkxU81SH1T73p//dUPb?=
 =?us-ascii?Q?g+ohOLQKpF/ITm3lhoFvy2EKirLOCG652dm/3UQJECqrfmdxzMf7Un8IFn0O?=
 =?us-ascii?Q?x1GBEjVsR/bDKUBt6ufuove7hUgZjbTTBbjJnSKD0+jDxMBDUCMC4yLdXa7G?=
 =?us-ascii?Q?4ALqbxbOVHnBS1JbXZZUCc1ARXPjxhoB72zyyozUeDjmz/y6+3dkrTajta5k?=
 =?us-ascii?Q?+9C0CEurHsyH+q1aP/vxlM37eHQKWTlrFI5aOEm+ByJAlHTvclX9cCoOMINi?=
 =?us-ascii?Q?s5Hj76OMhvTeINoSSUCLVdboZ0eCy6MinOz4mt4DlOOzKvancd+OlRGSj1C/?=
 =?us-ascii?Q?Ssl5EMFthYwt79UcIi8+9PmymDoTR9vk/X6/4SBF8eXC7aet4RXda4g1Ovnu?=
 =?us-ascii?Q?IAIc/PW2Tn04EM3B/vpmLoiAbw2DFruSXLMWDBOmJITbp3jFW9gWxLu0Xjn9?=
 =?us-ascii?Q?NLF5DjqpPidruCHOf38miWr6gcDQ9zwtE0St3nFaLW5/i7EEyslRUNjwN36Y?=
 =?us-ascii?Q?9lT82+Niubwc5foP7TIkkEV78DXW/okB/aJEtD9rjq6u/eFvlPv02hEbv4M4?=
 =?us-ascii?Q?PfDoq8CmifUB98Z8eYfUDcrmIcCUWm2s0zoKXiCLOWdz7dpQa02ldm12o868?=
 =?us-ascii?Q?VJmqFkZtKq8vgqk25eMp0jL0063YPHd1PBzZfHw/lYmcFLXu2gQSCPQ/SsjD?=
 =?us-ascii?Q?8dZlJvMTTjJLmZOziXJjnVlRBgD4BtiktJfWybPf+QsIls4Zvgpe4H0zxzxw?=
 =?us-ascii?Q?6kEPWjFRW0v8uOJGXiYSaJ9RSVg5LYmy7EgWr9nUwl88iB8JI5J0cgv9A6PA?=
 =?us-ascii?Q?qGS3tcP0Wfj3j7S3cf1z02a7O5Gwt1901zxXvsXhnUKC/BuOGMATkjB24MMv?=
 =?us-ascii?Q?tK755VAQbw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e166f79-79c5-4e6a-bf18-08da39644fd4
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 06:53:42.8795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k5wnaI8aDx3oR2yDMwcbzjYPC/MfcYWvlqk5sFP59ivuGjdRG9v2+63r626/Ux2OLwN/UN6ZrlfxAe9R5o+Dpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3966
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There has already been error check in clk_unregister(), so remove error
check before calling clk_unregister().

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 drivers/media/platform/atmel/atmel-isc-clk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/atmel/atmel-isc-clk.c b/drivers/media/platform/atmel/atmel-isc-clk.c
index 2059fe376b00..9decd8fb03d5 100644
--- a/drivers/media/platform/atmel/atmel-isc-clk.c
+++ b/drivers/media/platform/atmel/atmel-isc-clk.c
@@ -304,8 +304,7 @@ void isc_clk_cleanup(struct isc_device *isc)
 	for (i = 0; i < ARRAY_SIZE(isc->isc_clks); i++) {
 		struct isc_clk *isc_clk = &isc->isc_clks[i];
 
-		if (!IS_ERR(isc_clk->clk))
-			clk_unregister(isc_clk->clk);
+		clk_unregister(isc_clk->clk);
 	}
 }
 EXPORT_SYMBOL_GPL(isc_clk_cleanup);
-- 
2.20.1