Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760182AbXEOEN1 (ORCPT ); Tue, 15 May 2007 00:13:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754788AbXEOENU (ORCPT ); Tue, 15 May 2007 00:13:20 -0400 Received: from imx12.toshiba.co.jp ([61.202.160.132]:33405 "EHLO imx12.toshiba.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754645AbXEOENT convert rfc822-to-8bit (ORCPT ); Tue, 15 May 2007 00:13:19 -0400 Date: Tue, 15 May 2007 13:12:42 +0900 Message-ID: From: Tsutomu OWA To: Arnd Bergmann Cc: linuxppc-dev@ozlabs.org, Thomas Gleixner , mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [patch 4/4] powerpc 2.6.21-rt1: reduce scheduling latency by changing tlb flush size In-Reply-To: <200705141640.02561.arnd@arndb.de> References: <1179125506.22481.297.camel@localhost.localdomain> <200705141640.02561.arnd@arndb.de> User-Agent: Wanderlust/2.8.1 (Something) Emacs/20.7 Mule/4.0 (HANANOEN) Organization: Software Engineering Center, TOSHIBA. MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 34 At Mon, 14 May 2007 16:40:02 +0200, Arnd Bergmann wrote: > > On Monday 14 May 2007, Tsutomu OWA wrote: > > --- linux-2.6.21-rt1/include/asm-powerpc/tlbflush.h?????2007-04-26 12:08:32.000000000 +0900 > > +++ rt/include/asm-powerpc/tlbflush.h???2007-05-14 16:12:47.000000000 +0900 > > @@ -25,7 +25,12 @@ struct mm_struct; > > ?#include > > ?#include > > ? > > +#if defined(CONFIG_PPC_CELLEB) && defined(CONFIG_PREEMPT_RT) > > +/* Since tlb flush takes long time on Celleb, reduce it to 1 when Celleb && RT */ > > +#define PPC64_TLB_BATCH_NR 1 > With this code, you get silent side-effects of enabling PPC_CELLEB > along with another platform. Yeah, thank you for pointing it out. I'll send revised patch later. > Maybe instead you should change the hpte_need_flush() to always flush > when running on the celleb platform and PREEMPT_RT is enabled. Hmm... Is it in linux-2.6.21? grep'ing it did not help... Is http://patchwork.ozlabs.org/linuxppc/patch?id=10361 is the first place where the hpte_need_flush() appears? -- owa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/