Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 May 2022 17:35:27 +0200
From:   Frederic Weisbecker <frederic@kernel.org>
To:     "Paul E. McKenney" <paulmck@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Phil Auld <pauld@redhat.com>,
        Alex Belits <abelits@marvell.com>,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Yu Liao <liaoyu15@huawei.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Uladzislau Rezki <uladzislau.rezki@sony.com>,
        Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH 03/21] rcu: Add a note about noinstr VS unsafe eqs
 functions
Message-ID: <20220519153527.GE618878@lothringen>
References: <20220503100051.2799723-1-frederic@kernel.org>
 <20220503100051.2799723-4-frederic@kernel.org>
 <20220519145438.GJ2578@worktop.programming.kicks-ass.net>
 <20220519152611.GY1790663@paulmck-ThinkPad-P17-Gen-1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220519152611.GY1790663@paulmck-ThinkPad-P17-Gen-1>
Precedence: bulk

On Thu, May 19, 2022 at 08:26:11AM -0700, Paul E. McKenney wrote:
> On Thu, May 19, 2022 at 04:54:38PM +0200, Peter Zijlstra wrote:
> > On Tue, May 03, 2022 at 12:00:33PM +0200, Frederic Weisbecker wrote:
> > > Some RCU functions enter or exit into/from RCU idle mode while using
> > > trace-able and lockdep-aware IRQs (un-)masking. This could be easily
> > > solved with using raw versions of local_irq_*() but we would then
> > > lose some precious debugging informations.
> > > 
> > > Another possible way to solve this may consist in using rude RCU-tasks
> > > in lockdep and irqsoff tracing.
> > > 
> > > In any case and until this get solved, those RCU functions can't get
> > > tagged as noinstr even though they should.
> > 
> > FWIW, this also means RCU_NONIDLE() is broken. Luckily there aren't many
> > users left.
> 
> More to the point, rcu_irq_enter_irqson() and rcu_irq_exit_irqson() need
> the same help that rcu_idle_enter() and rcu_idle_exit() got earlier this
> week [1], independent of RCU_NONIDLE().
> 
> Unless Frederic beats me to it, I will queue something up.

It's in the patchset I just posted (02/21).

> 
> 							Thanx, Paul
> 
> [1] https://lore.kernel.org/all/20220518162118.GA2661055@paulmck-ThinkPad-P17-Gen-1/