Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1824562iob; Thu, 19 May 2022 15:59:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxs8Q0AL4Fjwdm5y1EWSlk/nRJNVwvL4BEaaipZ+CwlVSJDwJ8l1QURIzAagUbQbWUxhMhz X-Received: by 2002:a17:903:2308:b0:15f:3797:a755 with SMTP id d8-20020a170903230800b0015f3797a755mr6827764plh.122.1653001153107; Thu, 19 May 2022 15:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653001153; cv=none; d=google.com; s=arc-20160816; b=bNWVDrF09aWBZq/DDweCD8ZnNLbEA2l8pe+4Kki06WWXSQjhPnsix66Ub+4dP9hGbi pwr2yUbxw1CB1CQS5U05evgOD7k93z1tycVoPlqVrSA+J17dGICSynqvAA5YJru90C5A /BQHY39ZDXhoD8pDIld7dVtR+EMeMtkDFAdmDjZEC7GAvrRDdqp1Z92JA768oBLUWfbS hJONJIS2SN4cgCMSnFcFEtiKrxKt/+plrS4hYWs53fan1XWG6Nzc3jqs8M0DtK8wxt/w R+oMcsvjt+4NFd0BiIcENEMisOPJTN81MLpIVANG+S8j4LNeo/Ke00qpp3wLgrsIPTHf hEPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0yemFY16q8OLcHJ/TPE3DDfRmJA9UdQusq390kPKXYM=; b=Mp8QONDJoeQzv+LQbzky9aqfLInQsiHfNJCqtVy6fMXwDj9H3kq2oCe7Pn1w4kSovK 2GsUgrE1WwYzLqjvZEvc17D9CXQsttBx0M7nrH8/AE4V5ufT7Marule5zX+KeVkl1p+P ax7mD+g1i9kVnhCDrKgASfNDK2YUMGjsmJc3OR1p65S/wqf5hI16tmy/DAfKtyCPtbdN re/Z99+ohzj9j0ZqKOPQbb3ic4uzNn3eh2zKDw9HkfH15WAoVgoLAW6AUtNlru7ZKtAq +YwErRHIIrwV0+TPB4w4+Ousd7KQoi8luDBlWTSoE804poWwmLdSKb1r3EhE3RIyeA+z DIgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jrk0HJqi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hk8-20020a17090b224800b001dc82308e3asi1155453pjb.96.2022.05.19.15.59.01; Thu, 19 May 2022 15:59:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jrk0HJqi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241693AbiESPtX (ORCPT + 99 others); Thu, 19 May 2022 11:49:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241642AbiESPtN (ORCPT ); Thu, 19 May 2022 11:49:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A5CD108A83; Thu, 19 May 2022 08:45:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEBDF61BE0; Thu, 19 May 2022 15:45:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C921EC385AA; Thu, 19 May 2022 15:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652975134; bh=grMrez5z/qqSwQfDRZjfSNqC7wVFEopD1oJJWSiFoLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jrk0HJqiDHGsWZNXPq68+mIaObqaevRudF9yM+wIPbrZ967oq1V/YgY1OopBbe2GL Hu5bwu2Ue/AV2h3DJuSxElAYPYVqaOKx49MzyHwMNCvAVDV8QgBGXsob+KRyapthIn OKzOQ2/3INec1Nf6Txp/YOn9ek493BKfBSCPslwk= Date: Thu, 19 May 2022 17:45:31 +0200 From: Greg KH To: Denis Efremov Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, dan.carpenter@oracle.com, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, stable Subject: Re: [PATCH] staging: r8188eu: prevent ->Ssid overflow in rtw_wx_set_scan() Message-ID: References: <20220518070052.108287-1-denis.e.efremov@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518070052.108287-1-denis.e.efremov@oracle.com> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 11:00:52AM +0400, Denis Efremov wrote: > This code has a check to prevent read overflow but it needs another > check to prevent writing beyond the end of the ->Ssid[] array. > > Fixes: 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver") > Cc: stable > Signed-off-by: Denis Efremov > --- > > This patch is a copy of Dan's 74b6b20df8cf (CVE-2021-28660). > Drivers r8188eu and rtl8188eu share the same code. This does not apply to my tree at all. This file is not present anymore, what tree did you make it against? confused, greg k-h