Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 May 2022 21:00:40 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc:     Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
        Alberto Bianchi <alberto.bianchi@amarulasolutions.com>,
        linuxfancy@googlegroups.com,
        linux-amarula <linux-amarula@amarulasolutions.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: phy: DP83822: enable rgmii mode if
 phy_interface_is_rgmii
Message-ID: <YoaT2IrpO3mR/Nqh@lunn.ch>
References: <20220519182423.1554379-1-tommaso.merciai@amarulasolutions.com>
 <CAOf5uwni8tdr2srmp=X_uqs44_0Gtk_JuUoKSRoRFP2WhOfZVw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOf5uwni8tdr2srmp=X_uqs44_0Gtk_JuUoKSRoRFP2WhOfZVw@mail.gmail.com>
Precedence: bulk

On Thu, May 19, 2022 at 08:29:26PM +0200, Michael Nazzareno Trimarchi wrote:
> Hi
> 
> Il gio 19 mag 2022, 20:24 Tommaso Merciai <tommaso.merciai@amarulasolutions.com
> > ha scritto:
> 
>     RGMII mode can be enable from dp83822 straps, and also writing bit 9
>     of register 0x17 - RMII and Status Register (RCSR).
>     When phy_interface_is_rgmii this mode must be enabled
> 
>     References:
>     ?- https://www.ti.com/lit/gpn/dp83822i p66
> 
>     Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
>     Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
>     Suggested-by: Alberto Bianchi <alberto.bianchi@amarulasolutions.com>
>     Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
>     ---
>     ?drivers/net/phy/dp83822.c | 4 ++++
>     ?1 file changed, 4 insertions(+)
> 
>     diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
>     index ce17b2af3218..66fa61fb86db 100644
>     --- a/drivers/net/phy/dp83822.c
>     +++ b/drivers/net/phy/dp83822.c
>     @@ -408,6 +408,10 @@ static int dp83822_config_init(struct phy_device
>     *phydev)
>     ? ? ? ? ? ? ? ? ? ? ? ? if (err)
>     ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? return err;
>     ? ? ? ? ? ? ? ? }
>     +
>     +? ? ? ? ? ? ? ?/* Enable RGMII Mode */
>     +? ? ? ? ? ? ? ?phy_set_bits_mmd(phydev, DP83822_DEVADDR,
>     +? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?MII_DP83822_RCSR, BIT(9));
>     ? ? ? ? }
> 
> 
> 
> Please define bit 9 and this break other connection. Introduce again the switch
> for phy interface connection

Hi guys

Please try to perform your own reviews before posting to the list.

I agree with an #define for BIT(9).

However, i don't understand what you mean by the rest of your
comments. Please make sure your colleges understand you.

	  Andrew