Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Pavel Skripkin <paskripkin@gmail.com>,
        =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
CC:     Claudiu Manoil <claudiu.manoil@nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ocelot: fix wront time_after usage
Thread-Topic: [PATCH] net: ocelot: fix wront time_after usage
Thread-Index: AQHYa8CpkMuTuLmdfUG8uVuIyNZDm60m1HUA
Date:   Thu, 19 May 2022 23:13:01 +0000
Message-ID: <20220519231300.k6hizfdu5chi7lpu@skbuf>
References: <20220519204017.15586-1-paskripkin@gmail.com>
In-Reply-To: <20220519204017.15586-1-paskripkin@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Wbej8ZH3LRBgqQx5yj0WBugWwqEPDCeOx4IOla+dQIU7EsnodKh/NdV1pl?=
 =?iso-8859-1?Q?lRK4X5FSVnoeszDWgpLrVQHVA+Dihw2EbPBewEO8YcioZG/pQ3jc6kQsmb?=
 =?iso-8859-1?Q?7VRktLM+4IhrkeT+6Y/ta9TDIjN/knLHjcw2YNVZ6hfPBCrhnJc4QsSKqp?=
 =?iso-8859-1?Q?XlSuvfU+a+EubzrZLcS9xlxWQLGe8Bt3Z7PTYCiALdfbfJeQOoJom8ywPJ?=
 =?iso-8859-1?Q?1MnXDrjlaSKVqys1JVUynf4tqxfyGpNHYRdbqIx/s0ee1nDoZUS4KUcsV7?=
 =?iso-8859-1?Q?3CeyAXeS8yx9/XmBhIZpyzGhAFVAOyyI81VSQSAo7CXYrtX/Cl7afDAItr?=
 =?iso-8859-1?Q?VQPLoq1N6VNqAzIRyyiOKodujak09fa1i5OB7uq8XP1MSnfbbiBvxaiRi7?=
 =?iso-8859-1?Q?UsUTLoVEeUrl7zLgthvbhEGAjXDnBUA+s9vY1c7S+LKdu1OcEOtZAYoUZ1?=
 =?iso-8859-1?Q?BBHT673A977q4qCykhKN5KiPcABFxwjoqRvP9RK2MoAMqZQaGo1ROsaM0L?=
 =?iso-8859-1?Q?ubdRT+qXLB/vyhoacw2ZW/oH0/nEZB7Sk/SOtYMkHUbpiZmHHB4k8UnI7i?=
 =?iso-8859-1?Q?wcaESrx7xhrXiOSVJoA8rc0vLgA9urQJHU1B/zNdOL9XAv+JzWdTUGjOog?=
 =?iso-8859-1?Q?HrsuG7+ZcLXqDkoxEk93UMs0nqbf5ldznX/rmtqTz9bdXD1lIElPfZSbiq?=
 =?iso-8859-1?Q?Ps6pbqEsZHjU3LaYKZt8jzwhwkZCETyAnkLXbPKt1y7EV/Db/eALEXThux?=
 =?iso-8859-1?Q?+PZiVzh3P+XJc/NaHzlk2rQ2XNP8/Y7WazXBvNZnVFYxnzVecp4loGjQLP?=
 =?iso-8859-1?Q?V4q8y31KlQTAWJp+bpTNo5mtagcLecGSNxwQwlkPp9UfaKuigByfYwgzrm?=
 =?iso-8859-1?Q?REEdoDcT1DvvAWMWJtmunLIS7nFUYr+gljfdR0HMV/v6tgSON9TOAOuiqK?=
 =?iso-8859-1?Q?05P4pdzlAaYx8DWoD7nOeZTkOkFhjdvWIgGkb/eZagtkt0O82YTqEeCi46?=
 =?iso-8859-1?Q?E+4ewxqcg/kNSuHnfzq+VGdr3JDepneMXXBxCosEjophzuIHdA/TLiuOAc?=
 =?iso-8859-1?Q?PeMzlfWekaEunfQyQ0sZco4kxHpq0HhlWeeLuyK43Zzj+FXv0ul0RQc3N6?=
 =?iso-8859-1?Q?lhjLACUrDjDVwl0pSJ5WOZ6eJ14yYpgVNiynyglyRpOpOxqC+WgpjGV5vl?=
 =?iso-8859-1?Q?dbJr68SniRYo6LOwJV2YwyDYvOQgLr4LYPAbwsmASwgWO6N4cH1L1tDLEq?=
 =?iso-8859-1?Q?z0x2MxlBoyiPfEqD4p9Cj21PVkdvrit1TOOXVzsEUND3OC7jXrpLUpzcA6?=
 =?iso-8859-1?Q?KXvbLO10vWFxjScKdk+9jsotxrGLY0zed+R4EEjW9gZN/lvIK1C2ti4AWg?=
 =?iso-8859-1?Q?tl7bGs7Shto5StI4pguhJ3IG5JDny13Ld3k63mkUB/XAfHBxDwQbmk+y9Q?=
 =?iso-8859-1?Q?q6IzixQIlMYukar7j1NpBQfp++TkVXdsWyPIS4NbzquWWLz+mO30sRVB2A?=
 =?iso-8859-1?Q?rW1OlYcs9wiJesxxuOlLx54uYT7bRljQHJJqTJudGtTZ4eN5MPLnt5dC6O?=
 =?iso-8859-1?Q?u4S8JlLGehtmOY5vQf8t8vGBusYNheLtDd7+jGSTRI+NwPC9hHitdUCcVW?=
 =?iso-8859-1?Q?487DJGrGrXsN9X4cUdapv74pkIPGz7H/tIN0g0FZN8fT6rN/BFNex9aAZC?=
 =?iso-8859-1?Q?x3amuG+FOsOOBKSoAVuWcX4rN4RJ288+bnr5kZlsOYY5X7I0OvMl+Nl+xm?=
 =?iso-8859-1?Q?+n+4S/DIwln6ou1tVZMwa+7fakV1x+ZI0qsnOMZme5YspIHcn8GsiqW0be?=
 =?iso-8859-1?Q?mnc4l8s2QHYYgtEWJiw4Ti1xs2BSP7c=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <91315C6ABD636C44847A8AB68522EA7F@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4346d22-bfe6-4007-81ab-08da39ed1eb3
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 23:13:01.0990
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IDBaftsSu6cqsnsaweFeBb4UCaJTNJfHDZCRMCQ1aYF5n4gJ/ohMMCmdVoZsbAXV/ff33RLgmBeWm4PWD/ahBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3625
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 19, 2022 at 11:40:17PM +0300, Pavel Skripkin wrote:
> Accidentally noticed, that this driver is the only user of
> while (timer_after(jiffies...)).
>=20
> It looks like typo, because likely this while loop will finish after 1st
> iteration, because time_after() returns true when 1st argument _is after_
> 2nd one.
>=20
> Fix it by negating time_after return value inside while loops statement
>=20
> Fixes: 753a026cfec1 ("net: ocelot: add FDMA support")
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_fdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot_fdma.c b/drivers/net/ethern=
et/mscc/ocelot_fdma.c
> index dffa597bffe6..4500fed3ce5c 100644
> --- a/drivers/net/ethernet/mscc/ocelot_fdma.c
> +++ b/drivers/net/ethernet/mscc/ocelot_fdma.c
> @@ -104,7 +104,7 @@ static int ocelot_fdma_wait_chan_safe(struct ocelot *=
ocelot, int chan)
>  		safe =3D ocelot_fdma_readl(ocelot, MSCC_FDMA_CH_SAFE);
>  		if (safe & BIT(chan))
>  			return 0;
> -	} while (time_after(jiffies, timeout));
> +	} while (!time_after(jiffies, timeout));
> =20
>  	return -ETIMEDOUT;
>  }
> --=20
> 2.36.1
>

+Clement. Also, there seems to be a typo in the commit message (wront -> wr=
ong),
but maybe this isn't so important.=