Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2053192iob; Fri, 20 May 2022 00:13:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyM653fNoJLgGjR+o26bcgbkXxyRRVH6235DvmWJPmnXcnxEI/2dzGsaGr9DYjvBdDrj1pt X-Received: by 2002:a05:6402:1113:b0:428:679e:f73f with SMTP id u19-20020a056402111300b00428679ef73fmr9495145edv.378.1653030789852; Fri, 20 May 2022 00:13:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653030789; cv=none; d=google.com; s=arc-20160816; b=kZXRUPNkWXwszdWsDS8hRGzxVL9zfFSm0orYdzlQuB0SiaUlgpG9f5iGYfTu3Q26KR TjGO19JFHPLDwm6Slr/B1dPhocPvapeI+Wu+nd/4BAhoelcFbfPyHJgJoNveBL6jOePQ UJoK//Z6vjhDlg0c/bncLBUwm37goPAWaeBTYj4LPf361mCexnfLT3y3Pe+lZYVE5nW4 uQaOQZWF3SjUmMa8upYWlXyJieVyFfb3yjJGJAGzdewQPc4NZ4DVpoYMrY6vkAsBwWl0 uIE1MR46tomxNs5+qaTJmTiomWvWOi2FyZhsQy97EmaUQFQPz4HYHYaq7LdFHtrvbmlD CKEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VjzLZNFWnq32OoJjiMnVfMTg9IEgi4OMPr67a9sVT3I=; b=ENtIotnBSueFALTBwMYiI5zMwk85VRjtO+Nemj9zQhHHGWHY0vBE/YypaSXZbvbOUs 7OaJkvjQrKig+evRIFF/DFsVnIXLEGvPqj52sq/q9XZ/KIqePpGKd4jGAZAYoyITDvRX DSclNIWzaVAQ6TAXYcEnTKQATxvGBWn2nEw2VfR3cfnk3BrEUHi4WI/YkpExrrrSnfsf dCfaht8IPYu8enVRy5G+qQLar/Lvh88ApIoKTyzDmfaV8aUQZWBLT/l68+6OoKMBrMKT RauL2ZBMnEossFlGXLpqswcbqVvbRtZCBFAZHpii8s7/WkUsS5VCioRlrsqa8WBQYT9Q rWXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="q7JCdV/7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a056402274f00b00427bad2a2f7si9315842edd.324.2022.05.20.00.12.44; Fri, 20 May 2022 00:13:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="q7JCdV/7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244618AbiESUHa (ORCPT + 99 others); Thu, 19 May 2022 16:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244441AbiESUH3 (ORCPT ); Thu, 19 May 2022 16:07:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F9AD72217 for ; Thu, 19 May 2022 13:07:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D5DF61C58 for ; Thu, 19 May 2022 20:07:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 032B7C385AA; Thu, 19 May 2022 20:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652990847; bh=VjzLZNFWnq32OoJjiMnVfMTg9IEgi4OMPr67a9sVT3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q7JCdV/77UEkDqiOpRsCd+YOdaFP5aV4PZSTcuZs5m4pwtuUuzfC0UK76GwekffzR h+cFXDQw9e46VY4aK0TjDV5DtodUPSgG/qJQUgdGR3wGNzcG1FKqjPKuYmNPD/v1xN UzgAUs0TP/8hbnRaz/8LYvKF4WBeUKZcUJUPKwrFl9RDr+hpYELOHr0ygH2KHD10jo fci8ilsYXqWMhMIwjH1IvrTFXCyOohou3d4FlxkM5CnTehuiwi5UO1vroGzil4+Zq5 ve8OJOL0ljGdLL9XDzxEmBTo2RIGenwYIwxZ7pxltyJoGxybFEr10gWl88FjrH65s6 rshP6r3hP236g== Date: Thu, 19 May 2022 21:07:22 +0100 From: Mark Brown To: Alexey Khoroshilov Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] ASoC: max98090: Remove unneeded check in max98090_put_enab_tlv() Message-ID: References: <1652980212-21473-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jJAdLz6GK64fEyDl" Content-Disposition: inline In-Reply-To: X-Cookie: Some restrictions may apply. X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jJAdLz6GK64fEyDl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 19, 2022 at 09:27:25PM +0300, Alexey Khoroshilov wrote: > On 19.05.2022 20:54, Mark Brown wrote: > > Oh, the check won't be working properly - it's just that like I say the > > fix is to move rather than remove it so it's operating on the signed > > value. > Do you mean something like this? That looks about right. --jJAdLz6GK64fEyDl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKGo3kACgkQJNaLcl1U h9Bajwf/eGaouPOu8j/aU4kLc3j8bxbcRDfzLtUFL2wwu3VPEXy8/ToXspVWxomp JfUUtlcpdCahhDwSJ0uZ2aKUkWwmbPhjKH6iUrz2Kn/a4+m4MhROZMRUf1VAj+O8 r8YFZ6arWauRMQRPSVWfznlJlvnipMkfUMzFwYR0DeCWOt8+wrbybaEvFx3bQVG5 z0SMkWqoR75sL4e7lhy+aW+uENAMND8ghqbZu3+uxhvKdhkHEMlj/pHoj5AeAGya FjP+osfPtRa6nR0kM373UhZHyADEV/A16xLf6ttYbn1m6/g2mPAkypZ5axYaAnAM 8XQvvNrRZkoQqKQijhGeztx0I+0LjQ== =/nHu -----END PGP SIGNATURE----- --jJAdLz6GK64fEyDl--