Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7dbf218e-1a9a-13a4-6b6f-0e23899fb1cb@nvidia.com>
Date:   Thu, 19 May 2022 22:06:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style
Content-Language: en-US
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        netdev@vger.kernel.org
Cc:     outreachy@lists.linux.dev, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-kernel@vger.kernel.org
References: <20220520003614.6073-1-eng.alaamohamedsoliman.am@gmail.com>
From:   Roopa Prabhu <roopa@nvidia.com>
In-Reply-To: <20220520003614.6073-1-eng.alaamohamedsoliman.am@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVYwRnovOEY0M3FaRU1mYXozYmV6YjM4RmgxaWRIOUlMQmpDU1JPTFNLT1Ft?=
 =?utf-8?B?WVYvMERFL3FsMWl2QjFMNWlEZ0NMc21WbTVLVUJpRGlyR2FIUTBiamhVS3Iy?=
 =?utf-8?B?MUQwTStQdUJMSWJhMjh1QTVzVEJVWXVrdDUybTBXU3lYQkt3VnFnekhlb2xl?=
 =?utf-8?B?NlJmNzJkTDBsYkNJNFRQQkNPR2tYUmd4TTA2V05jbkQvVlF5YWxmOFEyS0c0?=
 =?utf-8?B?dkx6c1JRMzRVUWpqekJ5dTZNODBQQlNUTGluODJPOGpZMlEwRThiK0I5eEZ4?=
 =?utf-8?B?a1J3VWRyY1RkbUtEWU1WTzBRWG1IRnlDM3ZPM3Z4VzdGM21SZkpUK2tKcGp3?=
 =?utf-8?B?T3JRejN1bHFMeUZtTmw1TVR5bXVqbkZoNU5Kd0RDczd4MTk2UDExQ2JHZStN?=
 =?utf-8?B?V0tyekNiMGVXaGJBS3ROODhGSGFYejkxNjE5YllOaEF6eVNxcEpURlozNXBE?=
 =?utf-8?B?TGRDMVF1WVhWdE5tK3k1cWlYM1E2c3poZVhIRVUzaXRWbmZkemF1YVprcllO?=
 =?utf-8?B?dEtNN1ZpYWVpVG0vZjBPU0twYlhiRTRIclZWQUtSbnk1YzlDSzl3ZFg0ZHhO?=
 =?utf-8?B?bWkyakk2NkJMU1gwaFJuTDlocWZvS3RGR094T2VDR2NyejhJaWdSNWYzZjht?=
 =?utf-8?B?a1RsY0c1WjgreUtDUVZVNlhUdWhHbm5LME5TVkY0WEFnbm50cklobEZtMXV5?=
 =?utf-8?B?ZTFSQjRkU0NqdlZjd2hqOU9vb0NoNlp1V002Z3kzbVNnRWVjS1hTVVorYzUy?=
 =?utf-8?B?ZVRQaS9BU0FESEtTN3p4dWFxTnc0dlBlZDJLbDV4NXJMaS9HWTE1U2pZZDln?=
 =?utf-8?B?MkYxbURpd2NlU3NadTVTVHZZZklMVW9HV1U3dXFHdkdFUDduOW9kdVo5cWtI?=
 =?utf-8?B?YW05ZlVWbTBtZzdqblpYNm91bUtBMERNMm11ZE9DRXJFUTJsNE9LYmRTM3Zz?=
 =?utf-8?B?aG5vT0xzak5MN1lKMGlpRi9BTFBpbC9DdTZub2hNNUZSUTF4Y1pnUGM0ZTFX?=
 =?utf-8?B?Wk5FOUxnQndVcWU3TTIzaEE0STdzK2xuY2hjczVtdHhHTWJxREt0Z1YwaHRG?=
 =?utf-8?B?bGYwSVhpQ2FzTDh2RkRlSUh6bW1FK2ZyTVV2T0V1MzVadG1YdWhnallNWjMy?=
 =?utf-8?B?TEpoKzN6b1lKUlNEMnAvRk03eml1RWRuckZwSFZscitsL2hpUDl3L2Z6dVhr?=
 =?utf-8?B?OVZadytoQWx0TFV1dGloaUxHWmRJWDdjWWFTeG00VnJBejJpdGtiOUowWVJ5?=
 =?utf-8?B?NEYyblg3L0hCc1VLaXNJcVVqUTFrZkpuMEhpbmxTV3pwQkVLa2VMbVFBWlFP?=
 =?utf-8?B?cXJFMWRqNXVTalhLNEswckZMWTBYSzQ4ZklJb3Irck00azA0OHB0djJYRFZU?=
 =?utf-8?B?UTlkWS85TXl2VERrMi93Y2dib0RVU05lM3MyUUwxZVB4YkhpRklWUTN2Lzd2?=
 =?utf-8?B?TXgwNVg1azhwNGtjTEwrSksxS05TVVBLQ3VYdUVOQU1vN2RrYWhQa1NtWWZP?=
 =?utf-8?B?V2VodUI1eXpPNllYVGZGQXVEamR0K0U5L2ZjL3IyU1lZUGI3NHZHWEc2SDRS?=
 =?utf-8?B?bi9YN2NoTUg1dE1XTnVrdGJIaHhvL2lTT2oxUUVYUDdWL1hmU21RdEEvYlZE?=
 =?utf-8?B?V0JpdkFEOHJnVHlWRXJLdGNuaHJTZ0pGeUZuc0FwZDVsWnJYL2F6anA1eVJI?=
 =?utf-8?B?Z3BlVmF0ZnRZSEk2b1ZINGNnT0NubEJzT01QS3VYUlA5TjVrNXkrYk9BMlBt?=
 =?utf-8?B?N3JhOWY2ak9wL2FmNlpScFIxREdYQjZyRTExQVNKOXhxOUh6ZHpiWUhiVEda?=
 =?utf-8?B?bG1pSUh3ODhiWEwwRWprakhRREpKVDU5NDRkRkNLNHl1YlZ5dGNzMDVsZWpX?=
 =?utf-8?B?Q1NFeXd3TVhhdU1VNGl4YmRyZ3lTczZxbUhpZ2luczJHeTNwUjNRcGtEZWhW?=
 =?utf-8?B?K3VsRlp4T3dqMm5YZUlOTWVONmNLWlNseVZCNnRaYlB6R1hyOXhCb3pzQ0lR?=
 =?utf-8?B?dnN4c1pYOG51RDRmV0doVlJtVHhiVUV6WnI4RkhFL1VOTi80YXpJa3I5RGFs?=
 =?utf-8?B?Nk8yTFQrVEs4M1BiRnVaaEgvWjZqK2JCOE1JYkFBNWIwMlhkLzAyYXA1MG80?=
 =?utf-8?B?aTJNUmw2OXB2S1BRUkJVdDBYWjVBS01neFQxQ3I1UmxSaTN3ZmNxVTVRVEdr?=
 =?utf-8?B?VHFZM3ArSnFLQWROa2g4Mm9iRTNsbEpOOE9PYlUrSTJURmJXTjRmSVhoT2xl?=
 =?utf-8?B?NjNMeGYvNCtZNkduSTdVYXI5anpiaHltcHY3aHh6Q2NCRWt0WGU2ZTVZNjdP?=
 =?utf-8?B?RExhVDVUc1BiVjFOT2pzK29FQktkUnRhVEt2cVhxd0lTdzViZThGdz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05854892-6956-4291-6380-08da3a1e8f4b
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 05:06:55.5264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hMG5bDACBj+0SZLwrk5id2KT4qjim1VOjing2dchg1DHVFL5Mvtf2nOCYfECRje0EWpvBH/Glxx/6RM7ioRyOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5092
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/19/22 17:36, Alaa Mohamed wrote:
> The continuation line does not align with the opening bracket
> and this patch fix it.
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> changes in v2:
> 	fix the alignment of the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
>    string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
> ---
>   drivers/net/vxlan/vxlan_core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index 293082c32a78..29db08f15e38 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>   	if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
>   	    tb[NDA_PORT])) {
>   			NL_SET_ERR_MSG(extack,
> -						  "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
> +					"DST, VNI, ifindex and port are mutually exclusive with NH_ID");
it looks still off by a space.

>   			return -EINVAL;
>   		}


this closing brace should line up with the if

>   
> @@ -1297,7 +1297,7 @@ int __vxlan_fdb_delete(struct vxlan_dev *vxlan,
>   static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
>   			    struct net_device *dev,
>   			    const unsigned char *addr, u16 vid,
> -				struct netlink_ext_ack *extack)
> +			    struct netlink_ext_ack *extack)
>   {
>   	struct vxlan_dev *vxlan = netdev_priv(dev);
>   	union vxlan_addr ip;