Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2082429iob; Fri, 20 May 2022 01:14:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQio691HGwD9/MvBQ+EVCw94ej5I1Aip5RiA7Gj8KwQ5G7ODGRcxG7uwl82KAFdY19xWpf X-Received: by 2002:a17:902:6b0b:b0:158:f889:edd9 with SMTP id o11-20020a1709026b0b00b00158f889edd9mr8662018plk.122.1653034490745; Fri, 20 May 2022 01:14:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653034490; cv=none; d=google.com; s=arc-20160816; b=DOXufntrw7vgM3NJRk0R1os5zZ6mV96IhlMaij3M3stHixsnkrkTrEAXnsmY0yhJ0I my+ErUFa2CEX3Vk3HdzSHugb2yU7zl3ijvuoSP57byK6v6UHY4isd85fmExMkmRQnSZ3 c506gi7MAyZBrqy/i6bfEundLE+IRQUn3J4eN66uMY+zfBIIXU1t23+b+q1LEKMq2DXm oHtasl/XDpmCY1LDNJXW15oT3ZXP7mKhyAnruDhCJ7fgC1GA1gWri9HMrR8exYTC3v2n Ay3iZda+O/+Aw81R0xlWr2r6WMATtquQ5oQELmxQ0Sa4vJpLJsGesIyjKoXBAKtrPTl7 04fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=phlCsJ+hqKIKic4gKBAYBN/NiDv1dgcVI7okAVU6Jx8=; b=KpCydmM6AgK4OmuYeCRlY/Y7VV9Xdh1JxCngxbSvFCOqFh/C1s8Ffo+zwr2F73/Ym4 ChVo9ex0dbot4s7rEBo/DEsfTMd7ahopgeF2f/py7XZdv/t57/KjvYAqUE47fSgpsv1L mzlRmtLl3UghP27v2UbalpPpVj5mJqU8HAAEdijmlx7kS602cOgrCyEA1WT/+DUEqY8x wqxM4gT+ccdQiqVNl43VTKJLln2sO0AUV2XOZzAD7L2N/M526EiCTF2FaBQ91SZZ7QcR lizRdQ9efQKxYMI6qmVsbnGsC+QlolbeWWrONCHL3PdQl0LMTcrVSdyHiPFBaHw+xZQb oa6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kb6-20020a17090ae7c600b001dc758111afsi2455271pjb.108.2022.05.20.01.14.38; Fri, 20 May 2022 01:14:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238285AbiESQdD (ORCPT + 99 others); Thu, 19 May 2022 12:33:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233862AbiESQdB (ORCPT ); Thu, 19 May 2022 12:33:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CCF468304 for ; Thu, 19 May 2022 09:33:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E9CF461CAC; Thu, 19 May 2022 16:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FE9BC385AA; Thu, 19 May 2022 16:32:57 +0000 (UTC) Date: Thu, 19 May 2022 12:32:55 -0400 From: Steven Rostedt To: Vasily Averin Cc: YoPOhRctb8wwbmY5@carbon, Shakeel Butt , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Muchun Song , kernel@openvz.org, linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , linux-mm@kvack.org, Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , Michal Hocko Subject: Re: [PATCH v3] tracing: add 'accounted' entry into output of allocation tracepoints Message-ID: <20220519123255.543b8db6@gandalf.local.home> In-Reply-To: References: <20220518160447.20a7b96f@gandalf.local.home> <20220519100348.101d027d@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 May 2022 19:29:36 +0300 Vasily Averin wrote: > Frankly speaking I vote for performance with both hands. > However I'm still would like to avoid new sparse warnings. > Christoph Hellwig just recently taught me, "never add '__force' before > thinking hard about them", but in this case I would need to use it three times. > > I found that bitwise typecasts can be avoided by using translation unions. > > What do you think about following trick? It's really up to you memory management folks. Although I may need to update libtraceevent to handle the union case. That may be a bit tricky. -- Steve