Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2104013iob; Fri, 20 May 2022 02:00:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOdOyFOX+VYqJPGTkfw/eU1NhLZaoxLhsTuK6c/wUNF3sxpGyNpQlaQ7E1+pFe8yZZANXk X-Received: by 2002:a17:902:d2d2:b0:161:be0f:ccd7 with SMTP id n18-20020a170902d2d200b00161be0fccd7mr8734576plc.98.1653037202628; Fri, 20 May 2022 02:00:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653037202; cv=none; d=google.com; s=arc-20160816; b=CZNQTgdOOuNgZmAx6bwoZiDXrzc/Fwlhkyj+joaF6TIieyHrcb9/8q385GaZrDMxRr LzsuzCMRuxiTmpsJFL4HlBXy71X+p/Iji/OCdWzfWv0EA+EWrs430nIQWE0LOgqdNFme WQBi4HHkb8BKRJNW0OPSJj50iDQ63BFPJvRi9u1swOTOd77vD8bTK8S4GBaCXg1i27Iu LNBD3UdiA2VMsfiwHdU3Xcoq1HYEQMM8e7Ic/tZGQZPzYkH4ZWHnUCY7W47uJmFGzv8u 1+nNCqZhanIBJDZgEtGjefOU/oY8E2bGp0ybf8H9ab+h8P2NPjLOxTMgG2TslcZtjPwS eIug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DsVCetssUq+MreyZqK8zg9KjfkKzoqtweXeTJufo3Q4=; b=XuNfltSwpPvjRkvSCaKqpYDrAfWAomljKX3mRucAsxR5bJWOUwct7qP4OhzqkupNlz Q5viqQV2JulRqje2oJmBjKYfBTCXG7wxIm1CILfjGyAd82NeY9TGmv6jyfHjXjTBt4RP xcAKpqFAnvg8we/gyUoGwapjP8+wieB8Kyu6nREZ/IrnIsLXHXD3OPvaeMj8wCbKFteX FruaMbsae0Xiuj6muGx0fnLpqObTf7d35pSW5Ui4djD+M5liNZ50eg6eyj1BErTr3cTO hEWvYa75ENbu7hy9xwsNpo4a8SWLjederWropvlrTMEZVamw/Bec9RdOyMLlHLrDeAPK zQvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020a17090322c400b00158eb28cb9dsi10761998plg.254.2022.05.20.01.59.42; Fri, 20 May 2022 02:00:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244203AbiESTsq (ORCPT + 99 others); Thu, 19 May 2022 15:48:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240779AbiESTso (ORCPT ); Thu, 19 May 2022 15:48:44 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3076F1340 for ; Thu, 19 May 2022 12:48:42 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id CA1A168B05; Thu, 19 May 2022 21:48:38 +0200 (CEST) Date: Thu, 19 May 2022 21:48:38 +0200 From: Christoph Hellwig To: Jens Axboe Cc: tytso@mit.edu, Jason@zx2c4.com, hch@lst.de, linux-kernel@vger.kernel.org Subject: Re: [PATCHSET 0/2] Fix splice from random/urandom Message-ID: <20220519194838.GA6361@lst.de> References: <20220519193133.194138-1-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220519193133.194138-1-axboe@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2022 at 01:31:31PM -0600, Jens Axboe wrote: > Hi, > > We recently had a failure on a kernel upgrade because splice no longer > works on random/urandom. This is due to: > > 6e2c7421f02 ("fs: don't allow splice read/write without explicit ops") > > which already has more than two handful of Fixes registered to its > name... Yes. It was a hard break to get rid of set_fs and it's abuse.