Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2203316iob; Fri, 20 May 2022 04:32:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywO4zOe8U/kK8fEXxblx9uxabvSbDmhBBEAZfAmL3a5Jz8YyzJyp/j+fabZwPwJc1/8dTo X-Received: by 2002:aa7:d5c2:0:b0:42a:a9bf:a646 with SMTP id d2-20020aa7d5c2000000b0042aa9bfa646mr4084634eds.321.1653046353812; Fri, 20 May 2022 04:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653046353; cv=none; d=google.com; s=arc-20160816; b=KeIcEYaT8+EnMidPfVfAU4hpZfcwHrNQWYYliKM/hz3zZqwwfZotH3y3+qcpwYSlQS dhHKE+b2T3CKePFeXYxAdHLQvEEJl7RR5szq6YigbzyDmyUKL3FQh1kcO1+I3u/80cSw 6bbtjQzGhAAsplWZ3nCNJouYwr7X6AOG911yrE4lDWLP10NPp0hhlfig2F8fUUi2G3hw J/CxawY3b64O/A8qMECJcFIH1VGc/ImS06I3+i60DU0NVgiaXBmobozUl5ZxkH0pXxy1 X3hDoWeBnAeam5EtM0bOvvkUAP/T6Z1r2ryzofk/cBHBwYmmsgRfVEaR8VPO0BJqm/Te 0+uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dK+m5OZ/32GHXQ5STXOXQIXP5TX0/JRLtrhUNmulM1A=; b=M6CM08/WyuUlJfbN+QR/O2h6l3LqJKawEW0kr1E9pTsnuvOFsVuEVbpdvOCW6a9oH5 paewA9xJnQpjOSshKM9MjPz0jVTYwN8G8AFihlT2wpRHWUeNPjJ/akmPzDGtV/isTbwZ OqzajimNDM+YVFttRrxVQrDQWmRAO4p82EhOWV/lR25qU4A0euBqSi682+qXnUkHjP81 YNWu2kV07EXroU2uR9KZ7W87WWwKRcr+XOYFxky4tkKc68s5qBhC86RcbVYQOi4e/0R6 8FGBrecrntH5mJVyTtVaEh+kleRkjqb+eN4VND0NA1J3kHJb0ZGap7RzaPWyLsQ+LWc7 hBZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq4-20020a1709073f0400b006df76385f1csi7796249ejc.956.2022.05.20.04.32.06; Fri, 20 May 2022 04:32:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345576AbiETGCu (ORCPT + 99 others); Fri, 20 May 2022 02:02:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233504AbiETGCt (ORCPT ); Fri, 20 May 2022 02:02:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC70714AA79 for ; Thu, 19 May 2022 23:02:47 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id F2A14227A87; Fri, 20 May 2022 08:02:44 +0200 (CEST) Date: Fri, 20 May 2022 08:02:44 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , tytso@mit.edu, Jason@zx2c4.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHSET 0/2] Fix splice from random/urandom Message-ID: <20220520060244.GA16503@lst.de> References: <20220519193133.194138-1-axboe@kernel.dk> <20220519194838.GA6361@lst.de> <83183894-155a-efe7-ea0d-a3d88ebeadb1@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83183894-155a-efe7-ea0d-a3d88ebeadb1@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2022 at 01:55:26PM -0600, Jens Axboe wrote: > I'm a bit torn on this one, because I _really_ want us to get rid of > read/write and make everything use read_iter/write_iter. Firstly because > it's really stupid to have two interfaces, and secondly because even > basic things like "can we block here" doesn't work in the older > interface without fiddling with file flags which is a non-starter for > certain things. Converting everything was my initial plan, but Linus said no and just fix whatever breaks. And compared to my initial fears the fallout actually isn't that bad.