Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 May 2022 11:45:11 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Zhu Yanjun <zyjzyj2000@gmail.com>, linux-rdma@vger.kernel.org,
        Bob Pearson <rpearsonhpe@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Use kzalloc() to alloc map_set
Message-ID: <20220520144511.GA2302907@nvidia.com>
References: <20220518043725.771549-1-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220518043725.771549-1-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZCeOck/v0iv6WBRd0COScLJtt6EpU4PCS+g6Ra3IEED447S8ZGUpu/AM139r?=
 =?us-ascii?Q?mOifMl3HerEyGJqgNcPzIr5LLXY4VnWXjdQA3XE8oVjpSimpIh9wW/2XQziz?=
 =?us-ascii?Q?X5zXACSXI+TQ3Vvrch4PdTv8qV94KrLMDfToKu7e8meC+e+SdHlKuYDMtEnt?=
 =?us-ascii?Q?yuUbKrCgfi6L3I0gO9t49vUlcu+NyZgdGAc99s9LdJjjTT/nGz0//mFKr52P?=
 =?us-ascii?Q?tqEYr4rnk+NekslmuUa9/GAxTK+X48CvdPHNkXkGSTsXtCXPhTLDonlAY7Bw?=
 =?us-ascii?Q?c7sx5/j/AdXJndFh0OgtqyUC286bI+kyqnl0rbjS8Y1ZvKp0hu4XElAAtzuY?=
 =?us-ascii?Q?M6CuJwzj0OQmleQKF1dc4b0c+lh2sA6EpJoJGSOHSXu/gQheIO0nvt/soPSL?=
 =?us-ascii?Q?INOVB2mQYEgKhOAaKURpJR53P5Lb1ER1dtG6KaB5vRkT8iZ8f0rss8DBhBlq?=
 =?us-ascii?Q?wE8rK1m1p97gmmO6noHJizhGunQ275q0So7qzyq5ua81pANH/qiJT8s/MfBY?=
 =?us-ascii?Q?ktlailkBLTA5wIfU/QfVONBXUL4RP8xbVBB+Fy3dFj7MDumk8fdJC7Y1TSP9?=
 =?us-ascii?Q?sku3/b1xEaRWv5P7RRlA7fkLNeG3NTv24hXqQPn6OFsolK+UGbSpjUFBK2XK?=
 =?us-ascii?Q?qvc2CQqpdRJQawovLsatnTh0qrB63zCErPlPGt+EgUpt6N6asYabIiD4wHhP?=
 =?us-ascii?Q?dCCm/4NuZa0e9m7il9XTC0U8jFjoZk55OlxVLkh65mKcYEFvUPyWoj8B59L0?=
 =?us-ascii?Q?vFv98N7peNONn+AuvNfOg5qfNRSFgMPTWE5GkCPo4CGs02AYX5FXudUZwVDC?=
 =?us-ascii?Q?mnXdmyzRZOasCBYMiQmRF2T/NhPYjCxaBcusZAZDuNH1jH6eTcY2p64x99sN?=
 =?us-ascii?Q?VW5z1NlpQ+I+rFv0viTKrH/m84B0O9/Ao4pc29HrJvsvqhHZRcqd00BgO5JX?=
 =?us-ascii?Q?8jgz7Pq0W5Lp5lzzeAazBnEMzMOjAnMLJXrgvStM2PRT4u/Gmt+SPgXMPCj+?=
 =?us-ascii?Q?zroGU4ITQL7B1b6T25/vuMzusw/gAr7J+T08YJz26Lw8kRgL+r/7OayHK3a4?=
 =?us-ascii?Q?UPU1bbs3k49QKvI+ATOTywc41/TLgD+kmVyRD1CUKmiasYiyqqIwLH9U3KOl?=
 =?us-ascii?Q?Ozk03BtjNss0FVuaUNjkZhul3AeoyqNqfUDUDtAKPnVmYzawbQGKHi6x+kQP?=
 =?us-ascii?Q?dO2nvq4s7iGbkQErP/mQb1XeP4NR0jwKruRjtMFzbE7ie27INEw9JPW7VGcE?=
 =?us-ascii?Q?2lTqM+JPMY3tdIG9P4QQsU/Cw+MeDTHwHA9ajXoKEtljHp/He0KAAS2lj/c0?=
 =?us-ascii?Q?eZ8J7KWjdc/l6G80MjURDe70Y5rB1cqsTYxtbt668Jtml/dlxA3KYGV1/Ylm?=
 =?us-ascii?Q?ouqMbJ6tSx1xoaf5wTFnSFq4uV2mJZ1kb3fsfxBI1NCXtxrt1rNLNze1gjuf?=
 =?us-ascii?Q?Ng4QuHoWTAN2dqWts61hxQLnhFLDQF2ZFLNkDwx9fHDUKG2hkfWnekt+A8DC?=
 =?us-ascii?Q?ATKSQ2utjW+F8mIeWqkLrnaTvD00beGTJrXvI4RfUl+TNny2kD/ew4a31/sB?=
 =?us-ascii?Q?4VIAuHkkQWVal/AHRREZswLutEacFWbmdvXKQ2CKu3Y9yornn0YU0N9RpIut?=
 =?us-ascii?Q?LvFuKZWvNKqhaU4E1IQmQu198A97o4+IczwiKgClyFYpWZzsgZvBuf1APy2d?=
 =?us-ascii?Q?cBJaqVl83MZzhweRCkKwUuRYWN7g9JHHasS8KiaXPqmEzV7f6y5ETh4oJJoa?=
 =?us-ascii?Q?TmrKOjn5Uw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b53422ea-b3c4-4173-23f4-08da3a6f5908
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:45:13.8176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HNqR325knmxI+AkxQv0PtLBauXE3cqw9eEDu+oboqWMxYWgHSLbK8R5dQdkaw9fC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5805
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 18, 2022 at 12:37:25PM +0800, Li Zhijian wrote:
> Below call chains will alloc map_set without fully initializing map_set.
> rxe_mr_init_fast()
>  -> rxe_mr_alloc()
>     -> rxe_mr_alloc_map_set()
> 
> Uninitialized values inside struct rxe_map_set are possible to cause
> kernel panic.

If the value is uninitialized then why is 0 an OK value?

Would be happier to know the exact value that is not initialized

Jason