Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2422471iob; Fri, 20 May 2022 09:02:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/x30Zepw+exfefFuVlmFQM7pOpUgouEwmg6Vmf3ES+j8qteyGCcqx8y9ML9eY0BUai2oB X-Received: by 2002:a17:902:b941:b0:14d:af72:3f23 with SMTP id h1-20020a170902b94100b0014daf723f23mr10567674pls.6.1653062563752; Fri, 20 May 2022 09:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653062563; cv=none; d=google.com; s=arc-20160816; b=eMyiZ+WTBN9o0XQ3Otey4ZCj+fCxOMnacyOPEtHmxuWp2q9/vYaWITN1eQg2SM9npk BgmHpubTz5JoW0IFbLvObO+j9fhGvd1e9NX+LHl+ZTzsXESeywzxZFCscAQXeUr0bJP0 JTBTMRmKxY09RKA2IWFgNq+6APD+V5mqP2i12hzd+IX5dKYiHN6C+eXtta2nzmTb65uD GAQxrbxYg+/awx8dBdqPYWp4odWmJsIJ0+kqCibbhCzSOwoA6N7BfK3yixy/6lGMhaov qNeIHX+UM8u9uwk/XDpTtZom9JAhBeVKKxMOd1s27TAL7641Oh59f0E7e02V82+JHD26 JJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bM9WzwVvnjMxepM/Nw0GO5+XaC1YD0MYIscasVulL74=; b=RbchgOD/uGSRwK8ElR9Zg2GQdLYtt3mByBrCzK+Nk4qrlL+ydP69hed4PWoIFmQ7hu 9VEP1bCXNvRqywu/Ww8huoSiwEBvxm3QjHmH1BvsMUsqZ/aBwOtyxBS8xgGn9dha/68R GyFb5buerK1H8CbvZVSrPePnpl0sqQ4B8hzpEygx/DfNgLPjZGBKjx+8Y54DfSlsxfxf 7F1yzqT5r8REjuJtftU8+6ZB2kPxPqsluVSjw/TOTpBCwlXWIdG5DUkwhs9vi6ppJjek Q3hsHhr2qPcKtYi5HTiiHUe20AxQRSBajbRi1nKOTvfDYbXvxhdj/rCUTeDUwJvG/bEg 1sKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="t/DDrk80"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hk16-20020a17090b225000b001cb7551c772si3983697pjb.163.2022.05.20.09.02.25; Fri, 20 May 2022 09:02:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="t/DDrk80"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241902AbiESQvu (ORCPT + 99 others); Thu, 19 May 2022 12:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236304AbiESQvt (ORCPT ); Thu, 19 May 2022 12:51:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1F415A172 for ; Thu, 19 May 2022 09:51:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8EE0860B8F for ; Thu, 19 May 2022 16:51:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A14B4C385AA; Thu, 19 May 2022 16:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652979108; bh=LuK3ZmidX0cuWE1khNLjrTkNT3jkyQYbrGT/Q/UQVww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t/DDrk80rvv+zoD4GcdbFrafFXT7dQ1PbmR0/aMhFmzvJ5leo+RaYHWgKaLFnRViG OB+8B2YLe+Pi5JGpvUBDVOoRQsHhnSlp84DMDUbepjcxIuOxqbBPCYb5clz1D8wDBS sCmIwrn83QfShFb1gX4edobaaU+gI4KeTkzcJumA= Date: Thu, 19 May 2022 18:51:45 +0200 From: Greg Kroah-Hartman To: Won Chung Cc: Yu Watanabe , linux-kernel@vger.kernel.org, "Rafael J . Wysocki" Subject: Re: [PATCH] driver core: location: Free struct acpi_pld_info *pld Message-ID: References: <20220509173135.3515126-1-wonchung@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2022 at 06:51:13PM +0200, Greg Kroah-Hartman wrote: > On Mon, May 09, 2022 at 05:31:35PM +0000, Won Chung wrote: > > After struct acpi_pld_info *pld is used to fill in physical location > > values, it should be freed to prevent memleak. > > > > Suggested-by: Yu Watanabe > > Signed-off-by: Won Chung > > --- > > drivers/base/physical_location.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/base/physical_location.c b/drivers/base/physical_location.c > > index fbd9f9839e92..617ada542b00 100644 > > --- a/drivers/base/physical_location.c > > +++ b/drivers/base/physical_location.c > > @@ -32,6 +32,7 @@ bool dev_add_physical_location(struct device *dev) > > dev->physical_location->dock = pld->dock; > > dev->physical_location->lid = pld->lid; > > > > + ACPI_FREE(pld); > > return true; > > } > > > > -- > > 2.36.0.512.ge40c2bad7a-goog > > > > What commit id does this fix? Please add that and resend. > > thanks, > greg k-h Nevermind, I'll take it as-is.