Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2466805iob; Fri, 20 May 2022 09:59:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUtYYKK+LmM5dNXyaxexlMT24YR6ouwz8TarCPGkn0n106xFCZePUBM+DNwuH0TPllF1SQ X-Received: by 2002:a17:903:230b:b0:15e:bc9c:18c7 with SMTP id d11-20020a170903230b00b0015ebc9c18c7mr10693718plh.29.1653065989263; Fri, 20 May 2022 09:59:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653065989; cv=none; d=google.com; s=arc-20160816; b=j4JZImpTDnSJIVanCG8EXWFlVvOe6F/CYikFlsRTzH/coy+EwocodWaSupqSWsA1K8 6nVfj9/GxuIjsJ8pYjDR3OqylOsjEUykLq1TbMueVVACSN3dvexe8vafA9q5z/53EQsj CJeuU3dGD5UVy0plyJI6bxPISM+5nma+LTssijVu5RuxgGvyHWxcqR/7F/T8tGO4LmNJ G1WuCTOU7kAi3FliXesDNO5ryRyD2kv2gKfqpPvXUQALJFIL6l8w9sU0+8g/hyhwi3/G UvCz7jTMlAE3kwAtMcrw7wna0Ex1+KH6lSm0Z6UjA31tiJ1gh2H73Cf9Jdqn7qIn4Kty NdGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=cGpb7ZGnZmolqlcodDS+4Xrnr2MP+JxaiTVWAeuRPq8=; b=qPWUo2+Xe1mlRlevqN7vB068unmrEX02oDR5m2UNp8DIdnYnWegKwexKtWEoF9OPWO cJn+PCOqW5udBal8SpXK9+g+G/CE4LESnsCC9Fg9yMP+KxKs5jDkhHzYVmEe87bN/Lq1 kuD9kakbDE9rX7xQghIuKiGmRVSonUmOAIeaNaGN5rzwpYy+8xljJxlJJiXbnEwXbK/v 1xadvbX6D5rE429tThJhx+lBOODOJiztD/Aljpj0OnADd0ZaG4VCGvVGEb5dADTrkeSK bTyt6bqoz0/Dvyio64/GnPOVoW+M/0+GDhsKE2KHEYhRLVZSsMcDbylDxkRTWKx6bvEb i4og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=7K50c7Qr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a655cc7000000b003f5f2f73434si9924174pgt.550.2022.05.20.09.59.37; Fri, 20 May 2022 09:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=7K50c7Qr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343837AbiESXwg (ORCPT + 99 others); Thu, 19 May 2022 19:52:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343879AbiESXw0 (ORCPT ); Thu, 19 May 2022 19:52:26 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55A3C122B7E for ; Thu, 19 May 2022 16:52:09 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id h186so6356297pgc.3 for ; Thu, 19 May 2022 16:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=cGpb7ZGnZmolqlcodDS+4Xrnr2MP+JxaiTVWAeuRPq8=; b=7K50c7Qr3zfvvux1YsgYi0IeVwVi0vsOPEwdjD4VmEygxA0cAY9Qu+k/FAZg9egbRR cF3+ncwvI7jUd9+PYB1FhWc9MyS2bFcDJ6PTpTO6pyI2DDcOvsb7EJpjPhSEOJ57FM84 earrT+0CjWsmMSVWHxuuIWTpvNYkkkf7p+wKCF2PT0dHiArhfB6DbPHGUuoa4Otq1Yur OgxboR1ThofnFMtAy4weNpGwJ0aoSoMADy1a+ZGJJlYER7mp8rSZdsDXTJ30uGnHPMeg QYs4Cc6gS6qbnp7ni3dmyNsrTwyfMQsqcMX+FbuNnMLQBXePuHFNuJPpnNQLKi2FaraC 0xXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=cGpb7ZGnZmolqlcodDS+4Xrnr2MP+JxaiTVWAeuRPq8=; b=dO54Pm7aBTv4N7/Fw/9U4eOv+bn16h0qedYhTnZRNt1NEKwlJvYin3EFJiXJEgt5zc r8HfFjyraBuyIMb87LqdriRqdb3gZxhUrqZYTnPkr2lapYkidkUu7KuvCfAp2h/t241H Qlt9MPY05FFuN7TPyjM7X4Z+AO+9rmgIsZIIxG+jJ2OQAS+0RSPILoaZ6fNsYj/GG2Rc kypNyUaQ0Lt1XHfhy9FCyMKDG+b118VhrDeKWYHyNbOLq/ijFW3rljwzi/9l/8qILTKq i5RMpf5EAhRXMnupRcZ+zhY6NzmJNt8HiLo/HLyjiVEH74HYsFqgJDBNTfg19/WU8mZw kDiw== X-Gm-Message-State: AOAM5317ddmM5sbc/9/etwGlyhyUdDGTMh3kNVdd+y//tg5qsXHWzAr8 bXs+7XpXiSHrjUIAaEqQdhirulL2+/nmOw== X-Received: by 2002:a63:4d02:0:b0:3f5:db92:60b7 with SMTP id a2-20020a634d02000000b003f5db9260b7mr6125338pgb.580.1653004328778; Thu, 19 May 2022 16:52:08 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id i3-20020aa796e3000000b0050dc76281c8sm231664pfq.162.2022.05.19.16.52.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 16:52:08 -0700 (PDT) Message-ID: <8492c79f-3ddf-3b26-db9a-ff0f42bab7d9@kernel.dk> Date: Thu, 19 May 2022 17:52:07 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] random: convert to using fops->write_iter() Content-Language: en-US From: Jens Axboe To: "Jason A. Donenfeld" , LKML References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/22 5:43 PM, Jens Axboe wrote: > Now that the read side has been converted to fix a regression with > splice, convert the write side as well to have some symmetry in the > interface used (and help deprecate ->write()). Oh, and similarly to the other one, you can then add ->splice_write as well with using iter_file_splice_write for that. If you want to add that, please do. -- Jens Axboe