Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 May 2022 20:16:28 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Denis Efremov <denis.e.efremov@oracle.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        straube.linux@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        stable <stable@vger.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: prevent ->Ssid overflow in
 rtw_wx_set_scan()
Message-ID: <20220519171628.GW4009@kadam>
References: <YEHymwsnHewzoam7@mwanda>
 <20220518070052.108287-1-denis.e.efremov@oracle.com>
 <YoZmG98rI7oK5qgf@kroah.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YoZmG98rI7oK5qgf@kroah.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eHVGUuXGrNd8WxdHwumr2xwvVbp6Qu/r8cj8sBct8/oXx9L5cTfS3m/MhLYj?=
 =?us-ascii?Q?9z6EBg96wdgK9Tvgr1E6xJUFm0zIscd5cAqnhIItz/8/d9MzFbE3sKC3Mx2X?=
 =?us-ascii?Q?yzx2TYHgd11S2YqX3N0/eJ5c2iqlMZNt1vFLVDVCP2Zus8cK3lqqNxGuMDCe?=
 =?us-ascii?Q?Smg/i+Fa3e8p1pfcL2/fupGUCu28YVq29ptZDIlcbCMC9cO4InJHnHsS5TTo?=
 =?us-ascii?Q?cQ1YmPMsH1hupp1FX+0+rpS3t0Aax2+e7ysii2AJyeSxC7wvUXFOCnzpyyPf?=
 =?us-ascii?Q?G6HMFPbj5Z7x5ciVPOP461Nc49Ta3byl5Bv22OSSyifhkyXERA0jfagg6dm1?=
 =?us-ascii?Q?wdFgCw+qpW16xZ2LK2Ox1jd/KEn5JXp6fizo97tC6il1qFjVbb3jtLoUFvpX?=
 =?us-ascii?Q?yscUDVI4gjt1tqPqZyQ4IbWKCaCsd99ofKbHZ1zSZk9AKfmDYfrnuQnJOPpg?=
 =?us-ascii?Q?GV9H16mYHK3BPm8CfgvlzaQmSfcVuYot4Nlc2A4xnJ+9/C/sWnToxhQIe4pH?=
 =?us-ascii?Q?q0koUYLl1i6UHtJI8HeFwDqdZM4r1gvwk8yA3x+MOX1KxKGWhbnEne2EEr2e?=
 =?us-ascii?Q?KINcC8M1lmBzeH3sKGnVnHAaGxHTBGB5FuN1k+HG2eNfZrYKSnu5GwySZrK1?=
 =?us-ascii?Q?hfeyuExahqJhfrtmOdzbvSWwo08cnPYe/mK9viSNsHM00cJVILORe01u15jL?=
 =?us-ascii?Q?4/N4J9kNbYAQ9o7uAyB2FlSrNOBz621EpmdJgM7E+MzQdT/VgQlmFfem4ifX?=
 =?us-ascii?Q?Cd8YYEx15K4Tj4hyNurt8YV815/ZVN7RXNe6pO48McJ0RZLiAVAWrfLioiRh?=
 =?us-ascii?Q?A6lCbeoeH1jmgK6nQib8/ALeY6n+bP6HlhfDhDcax6unPN9r2Y068+vPm3/9?=
 =?us-ascii?Q?37tQ9Hsxnn1YQXWB8Fr8MMNCaS371KFa7WgaAEkdPYoC8tUwzerx15Oy0V8k?=
 =?us-ascii?Q?Pjn7tqc4n0R4w2g0y+SSjDwbj5wOh8exdjBlNSxFKgRwP3heXtag+p4VVpsU?=
 =?us-ascii?Q?jx5bueoQuYXR+4UlaZftP8xW07rzLnJyWkENqEuZ9UzSFFPs9v+JUbRk2OE2?=
 =?us-ascii?Q?Ox5afUaeFcWEhlavXw2Cbda+iYJJuEL80EIFYDdailc7Sd490K4eqNjtPppF?=
 =?us-ascii?Q?eZziAOO/IEIN93745Lq2PqUTqEYmZvnYL8bqwbDcpm4SsI3RChPtqQiWYO9d?=
 =?us-ascii?Q?FC29VLl50Zcgq9ijgBFp3fTb7xsLhicqHxkLojRz5hzomc6tKqoKz2f24ap5?=
 =?us-ascii?Q?8e9ZuyiUgIDsZaTrIdwzF33tEwo6U2Q3EYpk3oplumT9TzJFm3/OP0SyrL/u?=
 =?us-ascii?Q?H0xshblWdc/bJajPkdkZrYs8zCUFEVMARR+SJn1JcqtWg1Wg3LEWFoshnhiy?=
 =?us-ascii?Q?jT0p+3cAX/XgQZAkKhCqZiw/ICK2dimG/o/yxod1hfyaQNPZttnPKau3QO+F?=
 =?us-ascii?Q?8vdSP25C8gzgjrkq7WNZ7P26Sgdf93ZscyZFBbnlEXsQwMRSQlJhBFTqRr23?=
 =?us-ascii?Q?nVjDJ+kTouXINEfw+om/+ZdaK905QUxmND2Jj9WkSF97tmcqimYbqFS73zcy?=
 =?us-ascii?Q?OyMic/Ibs04epKsJL/NxRp9BI+dLOcTb5OZ8zwbEN3AWaUiWpLcWwgMqM3+Y?=
 =?us-ascii?Q?i+xkpOCoQTS9NzU6letvJPDmoqi4fvGfIoRjHrj4js6NFpoAkdZr1bqHYB63?=
 =?us-ascii?Q?WRFUvJ3dhuEq5GKqI339Ki1C4713lFivJwIxDBOtD2YgxvplmbHrXSaXOxLS?=
 =?us-ascii?Q?7VMeOyocg1cAHL0Hbyf6OKD0qgPMQK4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 641115bf-cf39-4de2-8304-08da39bb5b92
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 17:16:49.0436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1gH5fwEE8zvtk16iOcxi+Kz2s/N/2PL4YO7rj2gWZuXEdOBDxwuGjyKHaJ/P0Cp5loThn7eP9AvAKkY3AJJxrxkwcbFuBS+zcvbOi2f6ceM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5577
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-19_05:2022-05-19,2022-05-19 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 phishscore=0 bulkscore=0 mlxlogscore=959 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205190100
X-Proofpoint-GUID: 8wEfMrfKT-NecsXDjhcBcQwcBrLM3VpL
X-Proofpoint-ORIG-GUID: 8wEfMrfKT-NecsXDjhcBcQwcBrLM3VpL
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 19, 2022 at 05:45:31PM +0200, Greg KH wrote:
> On Wed, May 18, 2022 at 11:00:52AM +0400, Denis Efremov wrote:
> > This code has a check to prevent read overflow but it needs another
> > check to prevent writing beyond the end of the ->Ssid[] array.
> > 
> > Fixes: 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Denis Efremov <denis.e.efremov@oracle.com>
> > ---
> > 
> > This patch is a copy of Dan's 74b6b20df8cf (CVE-2021-28660).
> > Drivers r8188eu and rtl8188eu share the same code.
> 
> This does not apply to my tree at all. This file is not present anymore,
> what tree did you make it against?
> 

That's weird.  It applies fine for me on today's linux-next.

regards,
dan carpenter