Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 May 2022 10:02:41 +0200
Message-ID: <87leuwr5r2.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        "Mark Brown" <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
        <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
        Vitaly Rodionov <vitaly.rodionov@cirrus.com>
Subject: Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading
In-Reply-To: <87mtfcr5v1.wl-tiwai@suse.de>
References: <20220519174749.15459-1-vitalyr@opensource.cirrus.com>
        <20220519174749.15459-5-vitalyr@opensource.cirrus.com>
        <87mtfcr5v1.wl-tiwai@suse.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 20 May 2022 10:00:18 +0200,
Takashi Iwai wrote:
> 
> On Thu, 19 May 2022 19:47:36 +0200,
> Vitaly Rodionov wrote:
> > 
> > From: Vitaly Rodionov <vitaly.rodionov@cirrus.com>
> > 
> > This patch adds support for the CS35L41 DSP.
> > The DSP allows for extra features, such as running
> > speaker protection algorithms and hibernations.
> > 
> > To utilize these features, the driver must load
> > firmware into the DSP, as well as various tuning
> > files which allow for cusomtization for specific
> > models.
> 
> Wouldn't this sequence be required after S3/S4 resume?
> I thought cs35l41_hda_bind() is called only at the first binding.

OK, I see that the later patches in the series are about hibernation.
It might be good to mention that in this patch, though.


Takashi