Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp179606ioo; Fri, 20 May 2022 17:55:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdZskV4sy3zuH+NZMtzRh7zOYRrb/ANGk+kbJ3ypPnGX+vOQD56k/h6MMW2n3FF5ZY3X69 X-Received: by 2002:a17:906:b0c5:b0:6f3:bb5e:54a8 with SMTP id bk5-20020a170906b0c500b006f3bb5e54a8mr11314378ejb.534.1653094523066; Fri, 20 May 2022 17:55:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653094523; cv=none; d=google.com; s=arc-20160816; b=QSNU8ULVax3H2RESPnE/cXDHimj0vtbcYEPXthkl2LuzIVR217tP3nv5ee9FDkJB+Y Nh6ZyhNtKXzlFBeRk0+H5MvDt6ajluKgSmN5UGJMaaAmK8QOOkNXbKA/8+0xxFRF96dl LrCsNIm0X2a19OlyYvkNgzseFc4rIscVdIRQB+CstGBTHAQLLQSiHAZctBVexygNIQZQ Vmrcljm+z+JSXU9Ug2isSM0UvKgSRvUi/e/Xr4pdUFbWZmt9U/kt/BzjzVghnnBYHtsd 50pZOfdCHb8LG4Fu/Vf/AxblyWuCTMq0sPShEt8hH0kSXPKoAKBfZQ/KPbttp86d08// a7ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=w09xDaFhvCgd5/jtHMQ9zzqMXFg1Hmqji5SOkLVSX04=; b=FYWbMuKIA2+6QVwqcNKkG9k8+j+eUoqKGpiMObFG6Jc3VnuzK+ZiKGlFeB6yQeQwLP gTcy3CKwn1aiRrNIGDjbXZ6n5fD1oAwzqAf86jkWT94g9vC9kblSL3tVLOZlJ4BK+reZ tagrjFLvN55fT4pSUhW/RbsAkynEXAe/5Cys9z/S+KrLv4P8dCBRb96OKODJH1AukfHq 3hU79WPjxIORm+ngr0++AxVw8GSDCYP8O8tduLYoExcbObtxcUZSm+m3A8lLSvuI49ud EVi4BCeP7sHAvUX2ccqRrW1LgsMhMvpFRaWqQR/aZFZ6BsbnBme5RQumf42XG9qep5yU B6JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ECOahUtY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc32-20020a1709071c2000b006f4fe0e5576si731661ejc.34.2022.05.20.17.54.56; Fri, 20 May 2022 17:55:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ECOahUtY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351957AbiETQ6s (ORCPT + 99 others); Fri, 20 May 2022 12:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351966AbiETQ6q (ORCPT ); Fri, 20 May 2022 12:58:46 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4995E17DDDA; Fri, 20 May 2022 09:58:43 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id l13so8688208lfp.11; Fri, 20 May 2022 09:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w09xDaFhvCgd5/jtHMQ9zzqMXFg1Hmqji5SOkLVSX04=; b=ECOahUtY8/3WYgfZkQ8StYb8HVRRLhv4hCEnNfr7XbEzU6weV+kjDmrqGyjHiBK6SC Xkeeh4O081HIQtBhR3/96isJuNtcb54l+0FJ9SZoLYdyNe+5dRDBWpRhHO654doBe5t0 6w+TMedl8/iTrJYGdIaSqLEv3UqIGRkiJRI0i486D/gMGrBSFTUqZoZx2+bIJa4/8iqt uEaXgo2xbtpHgJg7ldB9gKcyXHVZNWT8uaW/yHXmbSv02YUCxx66BjBT3+WtQ+4xnBGg /vaB9W6g4zc9CEOfTDCPPY0BCW1rkXvphkqFdUs0X2OEQmDza+or1KjnYgkVs1Kf6N/M liTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w09xDaFhvCgd5/jtHMQ9zzqMXFg1Hmqji5SOkLVSX04=; b=ijo2sKcAmd10Fak2J1KLZFKvu6oBcZSlED37Ez81QNB0KGOPDgO34P+S/y1rCLnifm Pdw6pr0ig2CvbKgcnMktaxk0j3gCfUZQK0BnFF+qp4Tylv3yogGDt8DnU2uP2qlsjfbt gZ8SDPtmqAQVFd3ReTYRx0Pz/MEVVm1uwN57Dqa/0StursyPyPuEyaO1CeM3gCkfrpgG jCPvWnqohKp5eMP7rxJsAPtDepvacJi1eMDo3d6oL/HNpSF3jOLCnTtJQ0Eh9895h+Bh NpYSilD+J290jBhpZ47xXN5gjUBm5Bne1P+QJMb1K4P8wlUPO9YcEpYTkpyq1llLxSRS gyuA== X-Gm-Message-State: AOAM530cE2XmXoXVaPXHGBhYEh+KWeY6yOlsHtpv5gwWy8LYl7Ea073h wMsDDfk74B7XOYjKN9a0jLDMGAVXhwoSdRNSt0Q= X-Received: by 2002:a05:6512:318f:b0:473:dffc:18c8 with SMTP id i15-20020a056512318f00b00473dffc18c8mr7738530lfe.129.1653065921291; Fri, 20 May 2022 09:58:41 -0700 (PDT) MIME-Version: 1.0 References: <20220519101656.44513-1-duoming@zju.edu.cn> <87fsl53jic.fsf@kernel.org> <257f8e7.216cd.180dc1af4d3.Coremail.duoming@zju.edu.cn> <877d6h37c9.fsf@kernel.org> In-Reply-To: <877d6h37c9.fsf@kernel.org> From: Andy Shevchenko Date: Fri, 20 May 2022 18:58:04 +0200 Message-ID: Subject: Re: [PATCH net] net: wireless: marvell: mwifiex: fix sleep in atomic context bugs To: Kalle Valo Cc: duoming@zju.edu.cn, Linux Kernel Mailing List , Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:TI WILINK WIRELES..." , netdev Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2022 at 5:44 PM Kalle Valo wrote: > duoming@zju.edu.cn writes: > > On Thu, 19 May 2022 13:27:07 +0300 Kalle Valo wrote: ... > >> > Fixes: f5ecd02a8b20 ("mwifiex: device dump support for usb interface") > >> > Signed-off-by: Duoming Zhou > >> > >> Have you tested this on real hardware? Or is this just a theoretical > >> fix? > > > > This is a theoretical fix. I don't have the real hardware. > > For such patches clearly document that in the commit log, for example > something like "Compile tested only." It seems I even missed this part... :-( -- With Best Regards, Andy Shevchenko