Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 May 2022 09:50:24 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH v2] nvmem: brcm_nvram: check for allocation failure
Message-ID: <20220520065023.GB23160@kadam>
References: <20220510093540.23259-1-srinivas.kandagatla@linaro.org>
 <YoZ2ozeju8bXzUyX@kroah.com>
 <5b219857-4fe9-2406-2c6f-0511e8c33765@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5b219857-4fe9-2406-2c6f-0511e8c33765@linaro.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Uji6UQknE6X3usSyJKi8w419IDuogGG2J/K2IuOhfOc3jZc59MzFXajSodQ/?=
 =?us-ascii?Q?8YQfgC3V2EyXe+XASbfz3Yv/IL0t2DtocwOhGnpJI84YIT4uRj6iFvniGJ7Z?=
 =?us-ascii?Q?t2a9OXOiNYU6+OR+YVNrTaP4iAzICffyuMXjZJA6V6gsc6QV7BJrZExVI7bT?=
 =?us-ascii?Q?x2iEiU/Gd7k7unFYYC9nn5aUbAUbiTgFEBiSzoBpIduLGfO1Z55xZHYR9zbP?=
 =?us-ascii?Q?GfpWPbwfL4LiKTk1W6rBbrGcEQwT+nCB61oC87qPTeEMF3IzIOzd0Vck5bgN?=
 =?us-ascii?Q?r7toDkv0v7lw9RAFOFqL+wQH1DCv8GIZO6l4fTcwaA50O1MMDky/VPBsXKLE?=
 =?us-ascii?Q?3LroedkhriOkvLAOh/1ib8KGbdAkQ/d5f9Ngso5FOpBrM/gcMRMKNjGbT8SW?=
 =?us-ascii?Q?haczTNPkRnL6wKDhau/ugJWJ5HPzSBp0qhGyu0SLtE0KiLnsHb5IxrzskYif?=
 =?us-ascii?Q?eLw0d3jKBLtfeCImA0OYyVma7RAvWHpuApXW0iTbXUsv4SN/eKulQ2N4hovZ?=
 =?us-ascii?Q?7Sd4RYwBPS6Zt7GDwzi6dieDzzkJM2gAmcLn/9C07xP7PYsCe3Oy6QiwNJmX?=
 =?us-ascii?Q?ws0jVcYjbVYNCicfyCwFADNLNpAK1KPOjznMHtAA1f8uRzK+Kr1DUfOzn5X7?=
 =?us-ascii?Q?J6DpZi3UbLBkjE4gG/mARxJjlyi9df354FlDwD2ohPWU11APrQk62u9O0uUf?=
 =?us-ascii?Q?Qpcv7HjPhBbzm9XABvJ0NVY/qZziUJ5TDELODFd8Uzxnd6fCZd6p8ZCRLduG?=
 =?us-ascii?Q?CmShCveWbhinN65E128ZF5GqslYBkLA+4SD8s5hOVAug+nA5O6CyTkA1cnmd?=
 =?us-ascii?Q?qUilP3KMZjrhWq8NYimDaWGj6O5YaZk3skffrKirTdZ51fOviTZkC7EbCqi2?=
 =?us-ascii?Q?/e8p83KjxhyQZrRGwvtHHw+NhkbJQPgP7eJ6gRn6g8Zrixz/67/wiG9okTUQ?=
 =?us-ascii?Q?RF60ku0eVHUFpeYqnYM3LKKUde6hO56vebS68Sc9eaLafYobMQpjQCsXFYGJ?=
 =?us-ascii?Q?8tdHKU8qm6Ncup+kDGV+2fSHe/QQNYGygbaWk4vtyI2CjcgEGNEosKyS1V8e?=
 =?us-ascii?Q?2YrldL+sYtdVc9wqaryaWbNw8cC2CBf8MFHding8XQvW6RIne8rgF3Hg8Guv?=
 =?us-ascii?Q?DCF0sKFVuU/m4C2LOelDXUXGP8sDNFuBIcsp9Fo29j7XvWeaoR1U13VxEmdG?=
 =?us-ascii?Q?dHwo2ZBD7moHltIDRL8v0TabnUKP8EvpaJ6qYIqkh+ZOUGJL78gHPasylu4c?=
 =?us-ascii?Q?rKUmWriI7bDsUIyKpnI4FUfZYbz0iBxm/KtZQE9CUocVIp99QlVuk229T0s3?=
 =?us-ascii?Q?zvuKCyCgfZ1jUsQCThxc1tXTKZH8atWJ5GQBZCqKnSEluy8AV8uzFkH1RHY1?=
 =?us-ascii?Q?aPKYi8o6pHxmZk78s/DhFtf/zodAcjNMZFG5gb/PdAC4pvMlne5M49TIWrkh?=
 =?us-ascii?Q?SjD7N2TMUijgskXWYxwQDeqRFCQn2WXEn4KzwgSm2n5nOzcVOanjPPphEr3E?=
 =?us-ascii?Q?srHyGMHjqEBS2k4jZ/wylAtUTIlit9Khmse9z58dN+5TjKiimXxmL8bEvFIm?=
 =?us-ascii?Q?Gl8e4hoxgoa4/cvB9DrR7jiL3w8fN43UKP25a/VvxIq82sRJ8IGOdB8mxe/2?=
 =?us-ascii?Q?+6QnSm6AWxoM7mJGw3x623qRDd0gl4nkRl+AeYjy1bYfh20dog+fgDQOU2lb?=
 =?us-ascii?Q?dgD158zrljdM1v++h+c76m5SVWAEoB1ZYQztuLGLMLK4u/eaPszPbK0Wgy06?=
 =?us-ascii?Q?lCvEX3zj2pwUczoNAXmvg97vFeJzKJA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ebbc77e-54cd-40ef-f029-08da3a2d09db
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 06:50:34.3444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P/K5DG2V0E+EDHt9jKOPZBNyscQ+XGFePYaAHH+SKnHY//Mn4oE4ubIpWCtvwMwAmkEmEWsX7RcOQAgK9P/Kf5Fmiz+cSajnIQdBFvvIt3I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2107
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-20_02:2022-05-19,2022-05-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205200050
X-Proofpoint-GUID: o8YA8MOj_jjgq5p6TxEumobuDX8XxVTm
X-Proofpoint-ORIG-GUID: o8YA8MOj_jjgq5p6TxEumobuDX8XxVTm
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 19, 2022 at 06:03:56PM +0100, Srinivas Kandagatla wrote:
> 
> 
> On 19/05/2022 17:56, Greg KH wrote:
> > On Tue, May 10, 2022 at 10:35:40AM +0100, Srinivas Kandagatla wrote:
> > > From: Dan Carpenter <dan.carpenter@oracle.com>
> > > 
> > > Check for if the kcalloc() fails.
> > > 
> > > Cc: stable@vger.kernel.org
> > > Fixes: 299dc152721f ("nvmem: brcm_nvram: parse NVRAM content into NVMEM cells")
> > 
> > This isn't a commit in any tree that I can see, are you sure it is
> > correct?
> Looks like the commit is not correct,
> It should be
> 
> Fixes: 6e977eaa8280 ("nvmem: brcm_nvram: parse NVRAM content into NVMEM
> cells")
> 
> 
> Dan, can you send this with fix to Fixes tag?

No problem.  Done.

The problem is that Fixes tags will change if you use email instead of
git pulls.  Or maybe someone used git and did a rebase?  The point is if
you just use git everywhere and don't rebase then the hashes are
immutable.

No stress though, we figured it out.

regards,
dan carpenter