Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp356732ioo; Sat, 21 May 2022 01:07:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynuQWYQ2sYqh0Fm0BfKbaHGEGw4sPAYIN24XqBkV7fq6PPcCT2mpFPgbSJcpuiQ8K/3QIR X-Received: by 2002:a05:6402:5202:b0:427:f1a2:305c with SMTP id s2-20020a056402520200b00427f1a2305cmr14227988edd.39.1653120434757; Sat, 21 May 2022 01:07:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653120434; cv=none; d=google.com; s=arc-20160816; b=EB0PxeEjK0oN4tF8HjjIHUugoXHygiDnCgm9h/1mIIzhglGlHzlOJ/T3RD+4BwyLbQ lWqlZeqXGi1/RkGLS/OMLJdJ0bvd0BkK2ArE0+1aeG0A+UwNJWXLPzfPnrD1jPs689sn tiOgP81ijkFbMK19lUc/ivtaPz0vJsfydG5OYtxIf/pthWdhLreMMlB+aEeOlh/mFKiA RivkebOn7mrhVBs998fEL/ZAIwQQnG1DNiKOpyPhM9qV0rbc3vUi+hiwLcjgTi4P7yes I2lQxzCjFws5ewM5v6eF+Xr+gGY+ISiw+RwVFXDqla8dpNQz1qSmywcFvdNbTGHzjyYu 32mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=D4k2Cw/q+uLcOmHvMcwyqwODol2Cgrrywr4+z4BP+Lk=; b=fH3grEAiOgy6iqrZqzpb03lf7a3307C58r7z7nCwUVx0KoX2p50PBPYjwtLSBkeMTh IwxYfkxKsr3BnNZL65pKnBRS8uiU8U8ZgE1m/U8dlhGZYUiuE308VuqToUa5eAHAPacm MDZQpT4PBnZ///AyhWW6h3p6fXpXI8N+mXP486VKqg9+hHp4GDQQahWTssJYRlliW8Ii 8Q7lh8RRDXJomCoVwqMD2o+ahhBN7puIdUg5EvRNuMqHpr51ij0pNkcdKpo64PHo1tfy bzHzp9JPlaXlr81nxEWYhDi9TROEh/LD3pGdMg/4mcWyNdRgurb71kvA1zblOtbHIQW5 +Chw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NZPGC7my; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fu14-20020a170907b00e00b006f3911626bfsi8441237ejc.604.2022.05.21.01.06.36; Sat, 21 May 2022 01:07:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NZPGC7my; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243095AbiESRrr (ORCPT + 99 others); Thu, 19 May 2022 13:47:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243060AbiESRrn (ORCPT ); Thu, 19 May 2022 13:47:43 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C2A1AEE06; Thu, 19 May 2022 10:47:42 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id j28so7849821eda.13; Thu, 19 May 2022 10:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D4k2Cw/q+uLcOmHvMcwyqwODol2Cgrrywr4+z4BP+Lk=; b=NZPGC7mywR1LSs2MSRmrfM4/G/baLwFQDvGchz97c8iZD56lxjV1MSLz6EO9Bmqycp +LBcGEilfziTMQbD51XBtzuvuWcNoiEERJVtKWcodvfdzmv1EzpLIkPNk0gBJhHh5NvV 4gN4DeKnyBMxP7bP8BSjAnBu8r71waxkoH8VzneeN4iMmDwkVfdn8GtqA9hxGJg7tAzD 9TV2L5UsQ6iO2rZCR9ltcZxgJ5gPzDkSVvgIdIrbphrzFEyNTT0J96t9soeRjz1VoYSN YSj2fJEjzDzOI48NriXmUl2Mm2NNG+yPFkFRxy1v9LCSCRzRcLp8uw9ZSQV88pwBdOMA 8VJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D4k2Cw/q+uLcOmHvMcwyqwODol2Cgrrywr4+z4BP+Lk=; b=rCpy/EKe0yfa3yjzzzt2vbSLiwxJPh0w1i8jyrn8kFHRr2YGeAfux2MgchxVyyVQdc lcPEB6wj1PLxfzAh1TAyZ6QYitpP5rp/QymLoQs2wwmN0ZEF3CF98z5pNKTyyajGCw2j u8YUbYh+dSAX6k/7vwTJW4ecF8/0b9fSFp67ShaLHXb36VU+XnWaOAb6fII2UvIitAr0 J1lMmVga55jnEbgk0W9uBz+WZX17v3Vwpwthrf01OzdBMLznTeLikZ1cmDqvhgC+ujUt yiTPXaJ6M62OsaEK6O3uib+PGYJsDR/VuhCXU+EE6OFfPp3vGQZcd6VKshI5YEagXdSG GL+w== X-Gm-Message-State: AOAM5306jXqS8wFOzcNnzabaFuWtnYA+DQypwFLQig/w3alxP3EIOUMd HfL5jh3UKO8Pe7H+534qan0= X-Received: by 2002:a05:6402:3509:b0:427:e7db:1513 with SMTP id b9-20020a056402350900b00427e7db1513mr6598861edd.407.1652982460989; Thu, 19 May 2022 10:47:40 -0700 (PDT) Received: from skbuf ([188.25.255.186]) by smtp.gmail.com with ESMTPSA id v2-20020a17090651c200b006f3ef214e20sm2362633ejk.134.2022.05.19.10.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 10:47:40 -0700 (PDT) Date: Thu, 19 May 2022 20:47:38 +0300 From: Vladimir Oltean To: Martin Blumenstingl Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Hauke Mehrtens Subject: Re: [PATCH net-next v2 1/2] net: dsa: lantiq_gswip: Fix start index in gswip_port_fdb() Message-ID: <20220519174738.bgsxpzu5fh4yz6ij@skbuf> References: <20220518220051.1520023-1-martin.blumenstingl@googlemail.com> <20220518220051.1520023-2-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518220051.1520023-2-martin.blumenstingl@googlemail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2022 at 12:00:50AM +0200, Martin Blumenstingl wrote: > The first N entries in priv->vlans are reserved for managing ports which > are not part of a bridge. Use priv->hw_info->max_ports to consistently > access per-bridge entries at index 7. Starting at > priv->hw_info->cpu_port (6) is harmless in this case because > priv->vlan[6].bridge is always NULL so the comparison result is always > false (which results in this entry being skipped). > > Fixes: 58c59ef9e930c4 ("net: dsa: lantiq: Add Forwarding Database access") > Acked-by: Hauke Mehrtens > Signed-off-by: Martin Blumenstingl > --- Reviewed-by: Vladimir Oltean