Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220518025053.20492-1-zhoufeng.zf@bytedance.com> <cd5bb286-506b-5cdb-f721-0464a58659db@fb.com>
In-Reply-To: <cd5bb286-506b-5cdb-f721-0464a58659db@fb.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Fri, 20 May 2022 15:00:45 -0700
Message-ID: <CAEf4BzaE_WJBQ6xxMy8VmJy3OsPyCCjyRKi_F-CdPLwVVp+7Ng@mail.gmail.com>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: fix some bugs in
 map_lookup_percpu_elem testcase
To:     Yonghong Song <yhs@fb.com>
Cc:     Feng zhou <zhoufeng.zf@bytedance.com>,
        Shuah Khan <shuah@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        john fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
        Dave Marchevsky <davemarchevsky@fb.com>,
        Joanne Koong <joannekoong@fb.com>,
        Geliang Tang <geliang.tang@suse.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        duanxiongchun@bytedance.com,
        Muchun Song <songmuchun@bytedance.com>,
        Dongdong Wang <wangdongdong.6@bytedance.com>,
        Cong Wang <cong.wang@bytedance.com>,
        zhouchengming@bytedance.com, Yosry Ahmed <yosryahmed@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 18, 2022 at 8:44 AM Yonghong Song <yhs@fb.com> wrote:
>
>
>
> On 5/17/22 7:50 PM, Feng zhou wrote:
> > From: Feng Zhou <zhoufeng.zf@bytedance.com>
> >
> > comments from Andrii Nakryiko, details in here:
> > https://lore.kernel.org/lkml/20220511093854.411-1-zhoufeng.zf@bytedance.com/T/
> >
> > use /* */ instead of //
> > use libbpf_num_possible_cpus() instead of sysconf(_SC_NPROCESSORS_ONLN)
> > use 8 bytes for value size
> > fix memory leak
> > use ASSERT_EQ instead of ASSERT_OK
> > add bpf_loop to fetch values on each possible CPU
> >
> > Fixes: ed7c13776e20c74486b0939a3c1de984c5efb6aa ("selftests/bpf: add test case for bpf_map_lookup_percpu_elem")
> > Signed-off-by: Feng Zhou <zhoufeng.zf@bytedance.com>
>
> Acked-by: Yonghong Song <yhs@fb.com>


I've fixed remaining formatting issues and added my_pid check to avoid
accidental interference with other tests/processes. Applied to
bpf-next, thanks.