Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Juerg Haefliger <juerg.haefliger@canonical.com>
Date:   Sat, 21 May 2022 12:35:03 +0200
To:     Joe Perches <joe@perches.com>
Cc:     Juerg Haefliger <juerg.haefliger@canonical.com>, hca@linux.ibm.com,
        gor@linux.ibm.com, agordeev@linux.ibm.com,
        borntraeger@linux.ibm.com, svens@linux.ibm.com,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] s390: Kconfig: Fix indentation and add comments
Message-ID: <20220521123503.03da61da@smeagol>
In-Reply-To: <8d86b87edc9c9fa33b6a18fac8b160ee56e6a07c.camel@perches.com>
References: <20220520115708.147841-1-juergh@canonical.com>
        <20220520115708.147841-2-juergh@canonical.com>
        <8d86b87edc9c9fa33b6a18fac8b160ee56e6a07c.camel@perches.com>
Organization: Canonical Ltd
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/7C=1PIYdh2C/CG8EBl=OCo/";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/7C=1PIYdh2C/CG8EBl=OCo/
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Fri, 20 May 2022 10:15:38 -0700
Joe Perches <joe@perches.com> wrote:

> On Fri, 2022-05-20 at 13:57 +0200, Juerg Haefliger wrote:
> > The convention for indentation seems to be a single tab. Help text is
> > further indented by an additional two whitespaces. Fix the lines that
> > violate these rules.
> >=20
> > While add it, add trailing comments to endmenu statements for better
> > readability. =20
> []
> > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig =20
> []
> > @@ -607,7 +607,7 @@ config RANDOMIZE_BASE
> >  	  as a security feature that deters exploit attempts relying on
> >  	  knowledge of the location of kernel internals.
> > =20
> > -endmenu
> > +endmenu # "Processor type and features" =20
>=20
> An endmenu comment is relatively unusual.
>=20
> $ git grep '^endmenu' -- '*/Kconfig*' | wc -l
> 394
> $ git grep '^endmenu.*#' -- '*/Kconfig*' | wc -l
> 20
>=20
> I believe it doesn't really help readability.

Thanks for the review. Will send a v2 without that.

...Juerg

>=20


--Sig_/7C=1PIYdh2C/CG8EBl=OCo/
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEhZfU96IuprviLdeLD9OLCQumQrcFAmKIwFcACgkQD9OLCQum
QrfWSA/+LdHqfqWlzjHR038R4bbraz22SBsGuI4mCpDwU3gLzOKSbwxCyIr+0kG7
Ox6xDZnClHNHrQG8r+CmPYVY40Pla9Ta6E9oDouRe0m5hcpIoMmj3fD6K7q+b6PZ
3QKw6t2XIAYSfpvSkiStHRewjXc/R2wmaGuIqIFKZda6KTOKiHUBmlNUYKAsnBoR
C4CmUeCB+ky6ij6dZYYXEIxDl8ZBZnMGn938BJ2dHBu9cj7FcJyAik7v3Uc+a7RH
11RQGDqbRcHGGEC1woxv0oaZWwHzdcFumQy+hv1sbLmKGBHStXFRdoUF4NHiAYH3
3WrLE024lwnR8/ZpdClbvH661mWKY6ilNRGVMbDQ/4w9Pf5bXGFYrB2vIdK4aySr
5PIckHP5J0e2DYePlbdZabXXG71gs+yOOZ5kqA0Gv7PXpiaX53Vexop41v2e6b7y
4KpZ7mKiR+BopKxaT9/rKKilzByZc+wzg2oM+V/9gjHRnI9mbGAex1FG/hZGAKpk
0YGkf/X7edMx8fpotNtHB50F4twz3RBol2IFrh3fy1Nux17tCOShedUz9xKzkjes
iig6OdEji4uy3D+q0jwc+6HGtjMPVwze8y0kpZez5oZkqsGku6SjB/GiI+DV4zBf
5YtnG/VF+WA3LA6OKVdEaTyUoYQZ7zGP+bbMwG6pnEaNjo51QWw=
=Kwnk
-----END PGP SIGNATURE-----

--Sig_/7C=1PIYdh2C/CG8EBl=OCo/--