Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220519072649.1493706-1-treapking@chromium.org>
In-Reply-To: <20220519072649.1493706-1-treapking@chromium.org>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Fri, 20 May 2022 16:19:49 +0800
Message-ID: <CAJMQK-ipc73LUcK9qt8XtadFCiPTF6f_2Nrh_kdkt0UXgNx7ew@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: mt8173: Fix elm panel DT node
To:     Pin-Yen Lin <treapking@chromium.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 19, 2022 at 3:27 PM Pin-Yen Lin <treapking@chromium.org> wrote:
>
> Move the panel DT node under `aux-bus` node so it won't use the buggy
> `ps8640_bridge_get_edid` to get display modes. Also change the
> compatible string to "edp-panel" because the predefined
> `lg_lp129qe_mode` is not working.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")

Acked-by: Hsin-Yi Wang <hsinyi@chromium.org>

> ---
>
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
>  1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 9c75fbb31f98..1e0802a6f6d2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -90,18 +90,6 @@ volume_up {
>                 };
>         };
>
> -       panel: panel {
> -               compatible = "lg,lp120up1";
> -               power-supply = <&panel_fixed_3v3>;
> -               backlight = <&backlight>;
> -
> -               port {
> -                       panel_in: endpoint {
> -                               remote-endpoint = <&ps8640_out>;
> -                       };
> -               };
> -       };
> -
>         panel_fixed_3v3: regulator1 {
>                 compatible = "regulator-fixed";
>                 regulator-name = "PANEL_3V3";
> @@ -282,6 +270,20 @@ ps8640_out: endpoint {
>                                 };
>                         };
>                 };
> +
> +               aux-bus {
> +                       panel {
> +                               compatible = "edp-panel";
> +                               power-supply = <&panel_fixed_3v3>;
> +                               backlight = <&backlight>;
> +
> +                               port {
> +                                       panel_in: endpoint {
> +                                               remote-endpoint = <&ps8640_out>;
> +                                       };
> +                               };
> +                       };
> +               };
>         };
>  };
>
> --
> 2.36.1.124.g0e6072fb45-goog
>