Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20210904131714.2312-1-len.baker@gmx.com>
References: <20210904131714.2312-1-len.baker@gmx.com>
Subject: Re: [PATCH] clk: ti: composite: Prefer kcalloc over open coded arithmetic
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Len Baker <len.baker@gmx.com>, Kees Cook <keescook@chromium.org>,
        linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Len Baker <len.baker@gmx.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Tero Kristo <kristo@kernel.org>
Date:   Fri, 20 May 2022 20:40:23 -0700
User-Agent: alot/0.10
Message-Id: <20220521034025.5909FC385A9@smtp.kernel.org>
Precedence: bulk

Quoting Len Baker (2021-09-04 06:17:14)
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>=20
> So, use the purpose specific kcalloc() function instead of the argument
> size * count in the kzalloc() function.
>=20
> [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments
>=20
> Signed-off-by: Len Baker <len.baker@gmx.com>
> ---

Applied to clk-next