Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c51c9c6-e0d5-8616-8ba1-ef870bfb96ec@quicinc.com>
Date:   Sat, 21 May 2022 09:36:20 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] soc: qcom: socinfo: Add an ID for sc7180P
Content-Language: en-US
To:     Douglas Anderson <dianders@chromium.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     Stephen Boyd <swboyd@chromium.org>, <matvore@chromium.org>,
        Andy Gross <agross@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220520155305.v2.1.I26eca1856f99e6160d30de6d50ecab60e6226354@changeid>
From:   Sai Prakash Ranjan <quic_saipraka@quicinc.com>
In-Reply-To: <20220520155305.v2.1.I26eca1856f99e6160d30de6d50ecab60e6226354@changeid>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/21/2022 4:23 AM, Douglas Anderson wrote:
> Some sc7180 Chromebooks actually have sc7180P (known by many names,
> apparently, including possibly sc7180 Pro and sc7185). This is a
> sc7180 part that has slightly higher clock speeds.
>
> The official ID numbrer allocated to these devices by Qualcomm is 495
> so we'll add an entry to the table for them. Note that currently
> shipping BIOS for these devices will actually end up reporting an ID
> of 407 due to a bug but eventually a new BIOS will be released which
> corrects it to 495.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> Changes in v2:
> - Switch from 407 to 495.
>
>   drivers/soc/qcom/socinfo.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index cee579a267a6..c2c879ccc6c0 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -332,6 +332,7 @@ static const struct soc_id soc_id[] = {
>   	{ 480, "SM8450" },
>   	{ 482, "SM8450" },
>   	{ 487, "SC7280" },
> +	{ 495, "SC7180P" },
>   };
>   
>   static const char *socinfo_machine(struct device *dev, unsigned int id)

Reviewed-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>

-Sai