Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linuxarm@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: Fix memory ordering in hisi_sas_task_deliver()
Date:   Thu, 19 May 2022 21:09:11 -0400
Message-Id: <165300891232.11465.16554701363800250632.b4-ty@oracle.com>
In-Reply-To: <1652774661-12935-1-git-send-email-john.garry@huawei.com>
References: <1652774661-12935-1-git-send-email-john.garry@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 17 May 2022 16:04:21 +0800, John Garry wrote:

> The memories for the slot should be observed to be written prior to
> observing the slot as ready.
> 
> Prior to commit 26fc0ea74fcb ("scsi: libsas: Drop SAS_TASK_AT_INITIATOR"),
> we had a spin_lock() + spin_unlock() immediately before marking the slot
> as ready. The spin_unlock() - with release semantics - caused the slot
> memory to be observed to be written.
> 
> [...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: hisi_sas: Fix memory ordering in hisi_sas_task_deliver()
      https://git.kernel.org/mkp/scsi/c/6c6ac8b7773f

-- 
Martin K. Petersen	Oracle Linux Engineering