Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <b922eaa2-303a-69da-03ec-e053092c8682@lwfinger.net>
Date:   Sat, 21 May 2022 16:57:17 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v3] staging: r8188eu: add check for kzalloc
Content-Language: en-US
To:     Pavel Skripkin <paskripkin@gmail.com>,
        Martin Kaiser <lists@kaiser.cx>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     dan.carpenter@oracle.com, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20220518075957.514603-1-jiasheng@iscas.ac.cn>
 <20220521155017.7jjz7prdnspm2276@viti.kaiser.cx>
 <8fb49b5b-106b-3346-a75d-d54e0a065587@gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <8fb49b5b-106b-3346-a75d-d54e0a065587@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/21/22 15:26, Pavel Skripkin wrote:
> Hi Martin,
> 
> On 5/21/22 18:50, Martin Kaiser wrote:
>>
>>>      for (i = 0; i < 4; i++)
>>> @@ -1474,7 +1479,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter, 
>>> struct xmit_frame *pxmitframe)
>>
>>
>> res is still 0 here - but the caller of _rtw_init_xmit_priv compares
>> this return value with _SUCCESS (1) or _FAIL (0) and interprets it as
>> _FAIL.
>>
> 
> I think, it's time to make
> 
> s/_SUCCESS/0/
> s/_FAIL/-1
> 
> since developers from outside of staging are confused.
> The main problem will be with functions that return an int (or s32).
> 
> Will take a look.

I agree; however, this change will likely break a lot of pending patches.


@GregKH: Could you apply all pending patches in preparation for this patch? If 
so, then Pavel could make this transformation while the list is relatively idle.

Larry