Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1175794ioo; Sun, 22 May 2022 06:09:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeOehXmUMEfxJyzVQqZUQZ5hsX0txyvAjNMBr94ykG+Ozw2wSzkkY4XOyQ+rHeydtN9GEL X-Received: by 2002:a17:906:751:b0:6fe:a036:b357 with SMTP id z17-20020a170906075100b006fea036b357mr12623980ejb.185.1653224969094; Sun, 22 May 2022 06:09:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653224969; cv=none; d=google.com; s=arc-20160816; b=RYBm+kM90mp3HCWJr5Jxiny0M8EDxLdOQkikTwhCkueBN1RXR9F8nIB3LeTlHdKZCg Z90RI/yMLqSbXVll+xYxmRcxIEGBDpwked/j0vhXFx1+SWOjo9ciqKCfDwtyHBvgazza /vprgQxG9V5gmcSn0BqXat9HUvmpiUYkKr3WjTN3H9+DYQi2BYphgur1FlpGMv/UwwWQ 0npNCEwqNUHWNaNb8DRo7NZMbdQEDVakgjMODCh/bLVuNYhelV8XEccJ0X8HmY+sA/WO DBreQUzW04S+PvFrkuBi+mFnSVl/oogKyAbSvDKyhINkQiEL5lEDfu5X01oQn7Dbl/S8 yDpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=z9V1W249zALQzWHiAtZPoaL65EZlj/9URHZe/haLICQ=; b=jDmzYluCSwoT4rERbGcgnFdLoS4Zid3n3gdfdOCwDvJ7p+RmzNxVA+LWf0GLmta0MR x+UoJ3RVe1ygji1ih2fj50omgUMbOxaec3d4lQ4W+8BIvQjt5prZG9aqXbPzBdtnhmQz 7f+l1UvHsFzide6xRb01bKavip5waNsoLu3dFfMGoeLqlFOqwEDCD4CBLwi5j4m8yP+F SNqncv2kXEuFFO25A9zQ5BWUcmt2AKz5c1yQk/ZxDDsWADq3Bmir01NQW5JK4nQj2DoS xv9fuc0tSy3aTfs7+6J9NOcg9Ra/kfEQhS37eCfreqLcq0CLFptMB6pb2GSMaG+AQP8a noIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GLtfwI+l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y5-20020a50f1c5000000b00427b06dd893si11631126edl.632.2022.05.22.06.09.02; Sun, 22 May 2022 06:09:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GLtfwI+l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345269AbiEVMqQ (ORCPT + 99 others); Sun, 22 May 2022 08:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345258AbiEVMqM (ORCPT ); Sun, 22 May 2022 08:46:12 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F5D2F012 for ; Sun, 22 May 2022 05:46:10 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id y15so6666918qtx.4 for ; Sun, 22 May 2022 05:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=z9V1W249zALQzWHiAtZPoaL65EZlj/9URHZe/haLICQ=; b=GLtfwI+lhlzd1uVR2zN59m3yhU/Krnfw4ZVaEeTAX0yEIwZ0qmY2LNEGQMN1An+fe6 VX56+Fz/lvlsqyI95zH9LFDsSyBRlzKn3acrCIErD8igtr1XEjgeuR5JTFj6uYKobtgp RbdwdcZYl0H0H1GCBLzM7W84EdVGdBrTnxSj1OzwkK/P9+Dm37+SXSxXM+DmMM1//tC/ QRuWYmxiudtjnIIUMdOygFnmxt/Bsq+x7ij6XzCTXUvY/LZsgV42/M7wlXiL/BAAkhv9 Oze46thssYFPQ272e8I5cIgbE5Okmh6aLRk4BCKnQuqt0Aexo5i2c+H4/HDfGpig3UC7 b3lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=z9V1W249zALQzWHiAtZPoaL65EZlj/9URHZe/haLICQ=; b=07PUhkGewwQ+D+kQr/w8912MNRPX/3o6ahUY4+APq+UEF3zu4CYWTpzF3IV5yIiuk4 avu4DgM9nYk8PraRFpus9o4L5hsUWMstge57XcX6YFvgMPP7RBqxHmEjap3W4a/MdX5q K/HhJ8HREyx7UoJFdkRPWgrk4fQeAU1T1ZkQsEdz6o+eaRTaIClYCNiS9r4XpN1vNqBa HBxYWxjQBhdoEInySPK2pX0pRSBelUA987iBCOrKtzXjSo9G+e3C9y7Ugpi0dpw2hwqo Aka/eKYZ1cWvnyux0ZC0H06AIuCLRImmT+ssBtKX+1a5SsQ5f2HuRM2gf+7yphuXloQq 4/jw== X-Gm-Message-State: AOAM530NGhJPvCzJE+xHeuFYRjmcYCtuZkfLNN+9VwshsumRZTdC7MEk FyZPcnVfyZ9pr4drTDza4q+57Q== X-Received: by 2002:a05:622a:3c8:b0:2f3:ef89:fa28 with SMTP id k8-20020a05622a03c800b002f3ef89fa28mr13604105qtx.136.1653223569197; Sun, 22 May 2022 05:46:09 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id q24-20020a05620a0c9800b006a04256022bsm2710166qki.107.2022.05.22.05.46.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 05:46:08 -0700 (PDT) Message-ID: <59c6347c-2689-24bf-47b8-b635fef2e530@linaro.org> Date: Sun, 22 May 2022 07:46:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH net 0/2] net: ipa: fix page free in two spots Content-Language: en-US From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, evgreen@chromium.org, bjorn.andersson@linaro.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220522005959.1175181-1-elder@linaro.org> In-Reply-To: <20220522005959.1175181-1-elder@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/22 7:59 PM, Alex Elder wrote: > When a receive buffer is not wrapped in an SKB and passed to the > network stack, the (compound) page gets freed within the IPA driver. > This is currently quite rare. > > The pages are freed using __free_pages(), but they should instead be > freed using page_put(). This series fixes this, in two spots. > > These patches work for Linux v5.18-rc7 and v5.17.y, but won't apply > cleanly to earlier stable branches. (Nevertheless, the fix is > trivial.) > > -Alex I accidentally based this on net-next/master rather than net/master. Sorry about that. I'll send version 2 in a few days. -Alex > Alex Elder (2): > net: ipa: fix page free in ipa_endpoint_trans_release() > net: ipa: fix page free in ipa_endpoint_replenish_one() > > drivers/net/ipa/ipa_endpoint.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) >