Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <156a53a2-c33b-7ec5-3584-41ef25cb9cdd@linaro.org>
Date:   Fri, 20 May 2022 17:28:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Make timer
 selectable for ARCH_K3
Content-Language: en-US
To:     Tony Lindgren <tony@atomide.com>,
        Thomas Gleixner <tglx@linutronix.de>
Cc:     linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>
References: <20220408101715.43697-1-tony@atomide.com>
 <20220408101715.43697-3-tony@atomide.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <20220408101715.43697-3-tony@atomide.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 08/04/2022 12:17, Tony Lindgren wrote:
> Let's make timer-ti-dm selectable for ARCH_K3, and add a separate option
> for OMAP_DM_SYSTIMER as there should be no need for it on ARCH_K3.
> 
> For older TI SoCs, we are already selecting OMAP_DM_TIMER in
> arch/arm/mach-omap*/Kconfig. For mach-omap2, we need to now also select
> OMAP_DM_SYSTIMER.
> 
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>   arch/arm/mach-omap2/Kconfig  | 2 ++
>   drivers/clocksource/Kconfig  | 8 +++++++-
>   drivers/clocksource/Makefile | 2 +-
>   3 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -105,6 +105,7 @@ config ARCH_OMAP2PLUS
>   	select MACH_OMAP_GENERIC
>   	select MEMORY
>   	select MFD_SYSCON
> +	select OMAP_DM_SYSTIMER
>   	select OMAP_DM_TIMER
>   	select OMAP_GPMC
>   	select PINCTRL
> @@ -160,6 +161,7 @@ config SOC_OMAP2420
>   	bool "OMAP2420 support"
>   	depends on ARCH_OMAP2
>   	default y
> +	select OMAP_DM_SYSTIMER
>   	select OMAP_DM_TIMER
>   	select SOC_HAS_OMAP2_SDRC
>   
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -22,7 +22,7 @@ config CLKEVT_I8253
>   config I8253_LOCK
>   	bool
>   
> -config OMAP_DM_TIMER
> +config OMAP_DM_SYSTIMER
>   	bool
>   	select TIMER_OF
>   
> @@ -56,6 +56,12 @@ config DIGICOLOR_TIMER
>   	help
>   	  Enables the support for the digicolor timer driver.
>   
> +config OMAP_DM_TIMER
> +	tristate "OMAP dual-mode timer driver" if ARCH_K3 || COMPILE_TEST

Actually, I missed this. Could you convert to a 'bool' there is no 
module in the timer drivers ATM.


> +	select TIMER_OF
> +	help
> +	  Enables the support for the TI dual-mode timer driver.
> +
>   config DW_APB_TIMER
>   	bool "DW APB timer driver" if COMPILE_TEST
>   	help
> diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
> --- a/drivers/clocksource/Makefile
> +++ b/drivers/clocksource/Makefile
> @@ -18,7 +18,7 @@ obj-$(CONFIG_CLKSRC_MMIO)	+= mmio.o
>   obj-$(CONFIG_DAVINCI_TIMER)	+= timer-davinci.o
>   obj-$(CONFIG_DIGICOLOR_TIMER)	+= timer-digicolor.o
>   obj-$(CONFIG_OMAP_DM_TIMER)	+= timer-ti-dm.o
> -obj-$(CONFIG_OMAP_DM_TIMER)	+= timer-ti-dm-systimer.o
> +obj-$(CONFIG_OMAP_DM_SYSTIMER)	+= timer-ti-dm-systimer.o
>   obj-$(CONFIG_DW_APB_TIMER)	+= dw_apb_timer.o
>   obj-$(CONFIG_DW_APB_TIMER_OF)	+= dw_apb_timer_of.o
>   obj-$(CONFIG_FTTMR010_TIMER)	+= timer-fttmr010.o


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog