Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "tarumizu.kohei@fujitsu.com" <tarumizu.kohei@fujitsu.com>
To:     'Greg KH' <gregkh@linuxfoundation.org>
CC:     "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
        "eugenis@google.com" <eugenis@google.com>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "pcc@google.com" <pcc@google.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "marcos@orca.pet" <marcos@orca.pet>,
        "conor.dooley@microchip.com" <conor.dooley@microchip.com>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "marcan@marcan.st" <marcan@marcan.st>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 6/8] x86: Add hardware prefetch control support for x86
Thread-Topic: [PATCH v4 6/8] x86: Add hardware prefetch control support for
 x86
Thread-Index: AQHYaoDq7xJ4aiU+QEW7cdrhasBWQq0kMBYAgAMb2BA=
Date:   Fri, 20 May 2022 06:30:15 +0000
Message-ID: <OSBPR01MB2037623843E2507F7131945A80D39@OSBPR01MB2037.jpnprd01.prod.outlook.com>
References: <20220518063032.2377351-1-tarumizu.kohei@fujitsu.com>
 <20220518063032.2377351-7-tarumizu.kohei@fujitsu.com>
 <YoSVglItX1PhveEP@kroah.com>
In-Reply-To: <YoSVglItX1PhveEP@kroah.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?VGxMWjMxWTU5elptRmNvdjRUZEFtMHFzWFVhRmZxWndGRXRDM0J4SDcy?=
 =?iso-2022-jp?B?Y1NvVllIaWFHMnFWYngwSkhaU1FsUmdiUG10bWNvSGFYTVpJYkwrOFhq?=
 =?iso-2022-jp?B?d3BpSEFvM3I2WnRnMlVmcXhmNjRKeXR4azdMdDVFYVhjdDZwanZsY3U0?=
 =?iso-2022-jp?B?TG8wZmY1WFE1TXpmZVd0MW5wQ2dYYlZDNEZqV3JKc0ZFUUsxTEkvRmxQ?=
 =?iso-2022-jp?B?akdLMDZobDBOU2d5UXRiUXE4SkdrYzFLUWtjcXBvcFFiWGVRaTE3eXhS?=
 =?iso-2022-jp?B?T2lhV1o4VklVNWtvSmVtVnpTbDNuNkVjTCtUbVk1Nk1SMjdBSHhXaTFv?=
 =?iso-2022-jp?B?OERxNXE3YktWbVRRcWhlcXNZVTNTTzYrUlpOY3NTV0ozK0s2K0Ercjhv?=
 =?iso-2022-jp?B?eW42V29mYkxocFVJV0daajdWRnhKODN2ck5MRjVmbVBVVStRbWt3T3BS?=
 =?iso-2022-jp?B?VFNJUFZsaEkxaGlHVGhYWGhESWcrc0hRWEUrZTVNSUxxTVYzQVNZSUpU?=
 =?iso-2022-jp?B?QzYwZjNZTU1KYkkveWkwd2FpRllhZ2hMS2FLVjFER1ZxNURMdm9nWmNx?=
 =?iso-2022-jp?B?VFlZNncwVEJSTGdzUlVRZzVCQnpwenNJY2txU0xGcGlrRENPRjNCV2Vx?=
 =?iso-2022-jp?B?bE02Um92cEFCak9aZmw1NEdmUnkvR3laVGxxdytrcFBjUDZYWTdSZGs0?=
 =?iso-2022-jp?B?cmIrOFZwWVMrM0RTTjRIdHlCZmluRlNXWHlkN1pvN29MWitkZFdTTllw?=
 =?iso-2022-jp?B?c0FqN1k0MjlTUnpGS2FjR09LMXdyMzdEWnc1V0JkdE40cWU2OVJOc1Rn?=
 =?iso-2022-jp?B?bnRxLzVYYUcwVktuWVNnZnl6WXZEM2NOSmZGMXNtc2h6ajBZRDFtUGYy?=
 =?iso-2022-jp?B?K0drVDY1cWlzSEpVVG1aTnE3WHJSQ1lEMDYrUU5LNnpFU0RIS25qaFhv?=
 =?iso-2022-jp?B?VzVkajI5VjRQNDlyUEFJMUtDcE1NUzIzRUIxVHpMRHB0N2FDQzFJdkxJ?=
 =?iso-2022-jp?B?QXhVS0RXWGpKT2NhSUdUQzVsNWlKcGE4R0FnMXlHYTdUb1RIRXpHUFd6?=
 =?iso-2022-jp?B?NGtUTXZKRlV1QngvSVd4MkZuQ2ZyYkFiU09jRVRsSk5QUHRMZDJjVTNr?=
 =?iso-2022-jp?B?RVFDaEFseWRDVGo3cmM3bkpvc1F0RHk2SW43dHl4RXRidCt0TFhyTG1y?=
 =?iso-2022-jp?B?WThOV3NhVmRROFdZZmRibTd0RGFXc1NVbG1lOXE1RHNTcjJMaVdhTlhi?=
 =?iso-2022-jp?B?am0yaUZBTWF1VkR2UW5HUFJmR0thYlhWdktOMTZNL0pMT0IvdDZnV3BS?=
 =?iso-2022-jp?B?K21Kd2RQd2VVWXVYME9kckJoRGg4cmJkRDFHL3lxemFmcGY3MXk2NnpW?=
 =?iso-2022-jp?B?SXkvOVVrdzBuWEcxSTRLRkhiUlZHQUZkanpOR3o4SWNPZTFNa0kvR0dO?=
 =?iso-2022-jp?B?Y3UwVDROK2lWUGRSV0hyRnB2MEwwaXN3dVhqOXJvZmF4eDZxRkpuQXp5?=
 =?iso-2022-jp?B?ZThPYzJaZzFvR09HSjlQeDFET2lSSWFWcnRLaS9hYUlnZ1dXd0JXVlM2?=
 =?iso-2022-jp?B?eEg1ZElLMzFJVld6QjhJVjhsbCswZlpxMURVVUtKQUtzelhOUEsrTXVq?=
 =?iso-2022-jp?B?UnVvOXhZSFhtUjg3RkFHY3JBZzRHNHorazBDdEdGMk9zNVdERE1GOW9j?=
 =?iso-2022-jp?B?c1FseGsrZm9RZWJjS0dDdExMOVYyQnJUa2ZkVzNCQzYybSs1c0NNSnRN?=
 =?iso-2022-jp?B?eTg2NEwzRVI0OWRGaG1qOG5uazRJVWxQVStFOVVpaWw5YVZoUkVoOFhK?=
 =?iso-2022-jp?B?dEtYRWNLSHdKRk02V0xveE9mQkxqRllKUXBJT1hqSXM4bnBvc0c3MzYw?=
 =?iso-2022-jp?B?a0ZFWE80TGMxZjZBMVpBYVB5TVNNazJ6eU01a0NUSS9zQUp2NU91RHpn?=
 =?iso-2022-jp?B?MjNiWm9OZFc2QzBFUEM2RW9QUXhzZW1XMmlHeHc3TG9yaUZDNFdsbmJU?=
 =?iso-2022-jp?B?ZEF2SCtteFlsUlptUFQ3SCtBSlo0VDgzeXJpYVVSaUhpWVgxcWYwSGg1?=
 =?iso-2022-jp?B?MS9neVVOWm9vTVZ4a0RSQmVMcU4ydUF2RkJNZlhmSmJndTkzU1FHMlZ5?=
 =?iso-2022-jp?B?OVZTZVlLakJHRDBUTzNYYWhCMlhtWXNsWFVla3lHT084UG9sdk41ZEJD?=
 =?iso-2022-jp?B?M2RBYW1YLzF1a2JYKzkwbXF2VmFaTjIwMXl4YnJoSlYxcWlTUGQ0NzJt?=
 =?iso-2022-jp?B?MnBXL2tNejFhRU9SQ2d3ZlpYTkJVUlQxUFlrYSttZDF3Vit5SFhXMUtU?=
 =?iso-2022-jp?B?aFVSNStnNU5nQ1ZYOG55RE1kNjlOa1RqRkNoSmlqWlNTT2JqVW85QWZj?=
 =?iso-2022-jp?B?VHdpMitXbnRRTXZYWDBQQnh6QWhWUWhxR2JMS1ZCWlk3bjkrMUZOdk9Q?=
 =?iso-2022-jp?B?Yy9TbFZoRTg0cTdCT2IyNGhlcGhtQjg4RWNuY2ZkaHVqYlJyVUJWb3Rk?=
 =?iso-2022-jp?B?dGtZbmJQVThNU1pNc1h3UU1udXdKaUxvWHBIRHZsVXdDckhTajRZamVa?=
 =?iso-2022-jp?B?cUNGeWV5Yz0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB2037.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b525d429-27c7-4ed5-0b5f-08da3a2a33d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 06:30:15.8359
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WjNW+NsdKcw0Ydup3FewNdWJn8CkN/Na/CJ3aNfS8vB7uluPTrw6GzdKSrC3jP9eikm01ckjr2+Br5t+3l/riJwKMUL+AJk5+thQglY+4nQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB7028
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> As much fun as it is to see a function like this, that is not ok, and nev=
er guaranteed
> to keep working, sorry.  Please find the device properly, never assume a =
specific
> driver model topology as they are guaranteed to break over time and never
> supposed to be static like this.

I will consider a method that does not depend on a specific driver
model topology in the next version.

> How do you know attributes are to be marked read only after init?  Do oth=
er parts
> of the kernel do that?  I don't think the driver core guarantees that at =
all.

I will fix a proper marking in the next version.