Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 May 2022 23:44:02 +0000
From:   Adam Wujek <dev_public@wujek.eu>
Cc:     Adam Wujek <dev_public@wujek.eu>,
        Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: Adam Wujek <dev_public@wujek.eu>
Subject: [PATCH 2/3] hwmon: (pmbus) use block presence checking for registers PMBUS_MFR_*
Message-ID: <20220519234346.440398-2-dev_public@wujek.eu>
In-Reply-To: <20220519234346.440398-1-dev_public@wujek.eu>
References: <20220519234346.440398-1-dev_public@wujek.eu>
Feedback-ID: 23425257:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

When PEC is enabled, using the function to check byte register presence
(pmbus_check_byte_register) for block register generates an error.
The second byte of a block is interpreted as PEC, which is usually wrong.

Signed-off-by: Adam Wujek <dev_public@wujek.eu>
---
Note:
- This commit requires commit which is accepted, but not yet in the kernel
  tree:
  hwmon: (pmbus) add MFR_* registers to debugfs

 drivers/hwmon/pmbus/pmbus_core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_c=
ore.c
index 2634ac1fa3d5..597cbe85df07 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -2858,7 +2858,7 @@ static int pmbus_init_debugfs(struct i2c_client *clie=
nt,
 =09=09=09=09=09    &pmbus_debugfs_ops);
 =09=09}

-=09=09if (pmbus_check_byte_register(client, i, PMBUS_MFR_ID)) {
+=09=09if (pmbus_check_block_register(client, i, PMBUS_MFR_ID)) {
 =09=09=09entries[idx].client =3D client;
 =09=09=09entries[idx].page =3D i;
 =09=09=09entries[idx].reg =3D PMBUS_MFR_ID;
@@ -2868,7 +2868,7 @@ static int pmbus_init_debugfs(struct i2c_client *clie=
nt,
 =09=09=09=09=09    &pmbus_debugfs_ops_mfr);
 =09=09}

-=09=09if (pmbus_check_byte_register(client, i, PMBUS_MFR_MODEL)) {
+=09=09if (pmbus_check_block_register(client, i, PMBUS_MFR_MODEL)) {
 =09=09=09entries[idx].client =3D client;
 =09=09=09entries[idx].page =3D i;
 =09=09=09entries[idx].reg =3D PMBUS_MFR_MODEL;
@@ -2878,7 +2878,7 @@ static int pmbus_init_debugfs(struct i2c_client *clie=
nt,
 =09=09=09=09=09    &pmbus_debugfs_ops_mfr);
 =09=09}

-=09=09if (pmbus_check_byte_register(client, i, PMBUS_MFR_REVISION)) {
+=09=09if (pmbus_check_block_register(client, i, PMBUS_MFR_REVISION)) {
 =09=09=09entries[idx].client =3D client;
 =09=09=09entries[idx].page =3D i;
 =09=09=09entries[idx].reg =3D PMBUS_MFR_REVISION;
@@ -2888,7 +2888,7 @@ static int pmbus_init_debugfs(struct i2c_client *clie=
nt,
 =09=09=09=09=09    &pmbus_debugfs_ops_mfr);
 =09=09}

-=09=09if (pmbus_check_byte_register(client, i, PMBUS_MFR_LOCATION)) {
+=09=09if (pmbus_check_block_register(client, i, PMBUS_MFR_LOCATION)) {
 =09=09=09entries[idx].client =3D client;
 =09=09=09entries[idx].page =3D i;
 =09=09=09entries[idx].reg =3D PMBUS_MFR_LOCATION;
@@ -2898,7 +2898,7 @@ static int pmbus_init_debugfs(struct i2c_client *clie=
nt,
 =09=09=09=09=09    &pmbus_debugfs_ops_mfr);
 =09=09}

-=09=09if (pmbus_check_byte_register(client, i, PMBUS_MFR_DATE)) {
+=09=09if (pmbus_check_block_register(client, i, PMBUS_MFR_DATE)) {
 =09=09=09entries[idx].client =3D client;
 =09=09=09entries[idx].page =3D i;
 =09=09=09entries[idx].reg =3D PMBUS_MFR_DATE;
@@ -2908,7 +2908,7 @@ static int pmbus_init_debugfs(struct i2c_client *clie=
nt,
 =09=09=09=09=09    &pmbus_debugfs_ops_mfr);
 =09=09}

-=09=09if (pmbus_check_byte_register(client, i, PMBUS_MFR_SERIAL)) {
+=09=09if (pmbus_check_block_register(client, i, PMBUS_MFR_SERIAL)) {
 =09=09=09entries[idx].client =3D client;
 =09=09=09entries[idx].page =3D i;
 =09=09=09entries[idx].reg =3D PMBUS_MFR_SERIAL;
--
2.17.1