Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 May 2022 13:11:14 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Steffen Eiden <seiden@linux.ibm.com>
Cc:     Christian Borntraeger <borntraeger@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Nico Boehr <nrb@linux.ibm.com>, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/1] s390: Add attestation query information
Message-ID: <Yod3Uiu2hRc9vas7@osiris>
References: <20220518135908.1110319-1-seiden@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220518135908.1110319-1-seiden@linux.ibm.com>
Precedence: bulk

On Wed, May 18, 2022 at 01:59:07PM +0000, Steffen Eiden wrote:
> By design the uv-device does not check whether an incoming attestation
> measurement request only specifies valid plaintext flags or has the
> right request version, as these values are verified by the Ultravisor
> anyway. However, the userspace program that generates these requests
> might want to know which flags/versions are supported in order to
> create requests without trial and error. Therefore, we must expose the
> supported plaintext flags and versions to userspace.
> 
> since v1:
> 	* rebased on Janosch's "kvm: s390: Add PV dump support" series
> 	* added rationale as this cover letter

Thanks for adding the cover letter! However what I really meant (and
failed to write) is that the rationale should be part of the patch
description. Anyway; whoever picks this patch will hopefully integrate
your cover letter description into the commit.