Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59b140a2-fd9d-f5a7-85e0-9ff712e468df@huawei.com>
Date:   Fri, 20 May 2022 15:53:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module
Content-Language: en-US
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
CC:     <alexander.sverdlin@nokia.com>, <ardb@kernel.org>,
        <linus.walleij@linaro.org>, <nico@fluxnic.net>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20220401131534.241205-1-chenzhongjin@huawei.com>
 <YoOu1Ng53Tv/ec0d@shell.armlinux.org.uk>
From:   Chen Zhongjin <chenzhongjin@huawei.com>
In-Reply-To: <YoOu1Ng53Tv/ec0d@shell.armlinux.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/5/17 22:19, Russell King (Oracle) wrote:
> Hi,
> 
> On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote:
>>  struct mod_arch_specific {
>>  #ifdef CONFIG_ARM_UNWIND
>> -	struct unwind_table *unwind[ARM_SEC_MAX];
>> +	struct unwind_table unwind_list;
> 
> Why is this not a:
> 
> 	struct list_head unwind_list;
> 
> because, from what I can tell, the _only_ member that is used in this
> struct unwind_table is the "mod_list" member - so everything else is
> entirely unused and redundant.
> 
> Thanks.
> 
Thanks for review!

I have updated it to v5 with two other fixes. Also updated it on patch tracker.

Best,
Chen