Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <b49d037c38715c3fd82c07309e32aad70c97890b.camel@perches.com>
Subject: Re: [PATCH v2 4/5] clang-format: Fix empty curly braces
From:   Joe Perches <joe@perches.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= <mic@digikod.net>,
        Miguel Ojeda <ojeda@kernel.org>,
        Andy Whitcroft <apw@canonical.com>,
        Brian Norris <briannorris@chromium.org>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        "Jason A . Donenfeld" <Jason@zx2c4.com>,
        Kees Cook <keescook@chromium.org>,
        Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Paul Moore <paul@paul-moore.com>, Tom Rix <trix@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
Date:   Fri, 20 May 2022 11:00:00 -0700
In-Reply-To: <CANiq72=e9LMujmsk-mh8YHcGoKuLAnBttNz7JbiXH_2-hpvUvw@mail.gmail.com>
References: <20220506160106.522341-1-mic@digikod.net>
         <20220506160106.522341-5-mic@digikod.net>
         <CANiq72kbp3xTpj-L2BfLQ1Ecx-2Ki0W3e5YLERx8-T9bjb96=g@mail.gmail.com>
         <5be32ddf7688db38408466315a80e03e9af7ac40.camel@perches.com>
         <CANiq72=e9LMujmsk-mh8YHcGoKuLAnBttNz7JbiXH_2-hpvUvw@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-05-20 at 19:50 +0200, Miguel Ojeda wrote:
> Hi Joe,
> 
> On Fri, May 20, 2022 at 7:24 PM Joe Perches <joe@perches.com> wrote:
> > 
> > static inline void foo1(...) {}
> > static inline void foo2(...) {}
> > ...
> > static inline void fooN(...) {}
> 
> Those are the non-wrapped-from-signature case, which are handled
> before this option takes place, i.e. this option is about:
> 
>     void f()
>     {}
> 
> vs.
> 
>     void f()
>     {
>     }
> 
> For putting everything on the same line, we could adjust
> `AllowShortFunctionsOnASingleLine` from `None` to `Empty`, though.

As you wish.

I think it's more that there's no "one true style" issue than anything.