Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 20 May 2022 17:40:20 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Roopa Prabhu <roopa@nvidia.com>
Cc:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        netdev@vger.kernel.org, outreachy@lists.linux.dev,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style
Message-ID: <20220520174020.3cffce01@kernel.org>
In-Reply-To: <7dbf218e-1a9a-13a4-6b6f-0e23899fb1cb@nvidia.com>
References: <20220520003614.6073-1-eng.alaamohamedsoliman.am@gmail.com>
        <7dbf218e-1a9a-13a4-6b6f-0e23899fb1cb@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 19 May 2022 22:06:53 -0700 Roopa Prabhu wrote:
> > @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
> >   	if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
> >   	    tb[NDA_PORT])) {
> >   			NL_SET_ERR_MSG(extack,
> > -						  "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
> > +					"DST, VNI, ifindex and port are mutually exclusive with NH_ID");  
> it looks still off by a space.
> 
> >   			return -EINVAL;
> >   		}  
> 
> 
> this closing brace should line up with the if

Let me just fix this myself when applying... There were 3 separate
postings of v2, and they weren't even identical :(