Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757585AbXEOSgj (ORCPT ); Tue, 15 May 2007 14:36:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755118AbXEOSgb (ORCPT ); Tue, 15 May 2007 14:36:31 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:46145 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754948AbXEOSga (ORCPT ); Tue, 15 May 2007 14:36:30 -0400 Date: Tue, 15 May 2007 20:37:25 +0200 From: Sam Ravnborg To: =?iso-8859-1?Q?J=F6rn?= Engel Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, akpm@osdl.org, Albert Cahalan , Thomas Gleixner , Jan Engelhardt , Evgeniy Polyakov , Pekka Enberg , Greg KH , Ingo Oeser Subject: Re: [PATCH] LogFS take three Message-ID: <20070515183725.GA22003@uranus.ravnborg.org> References: <20070515151919.GA32510@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20070515151919.GA32510@lazybastard.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 37 On Tue, May 15, 2007 at 05:19:20PM +0200, J?rn Engel wrote: > [ I have put everyone that gave comments to the last patch on Cc:. Hope > that doesn't offend anyone. ] > > > Add LogFS, a scalable flash filesystem. Have you run sparse on this code? I do not recall if you have written something about it. I do not see any obvious things sparse would catch (just browsing quickly) but it's always a good thing to do. +++ linux-2.6.21logfs/fs/logfs/progs/fsck.c 2007-05-15 00:54:22.000000000 +0200 @@ -0,0 +1,332 @@ +/* + * fs/logfs/prog/fsck.c - filesystem check + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007 Joern Engel + * + * In principle this could get moved to userspace. However it might still + * make some sense to keep it in the kernel. It is a pure checker and will + * only report problems, not attempt to repair them. + */ +#include "../logfs.h" + If potential userspace tools needs to include ../logfs.h then there is something that ought to be moved to include/linux/logfs.h instead. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/